[Marble-devel] Review Request 108616: QtMainWindow: unify Render Plugins Menus

[Thibaut Gridel]

> On Jan. 27, 2013, 4:18 p.m., Torsten Rahn wrote:
> > src/QtMainWindow.cpp, line 408
> > <http://git.reviewboard.kde.org/r/108616/diff/1/?file=109370#file109370line408>
> >
> >     I've always disliked having a "Tools" section: It has the danger of becoming a "dump everything else here" place (like the awful "Plugin" or "Tools" menus in other apps do).
> >     Instead plugins should announce themselves where they should go inside the menu (like discussed with Rene). An "Edit-mode" Plugin would for example announce that it would provide a "topLevel" Menu "Create" with menu entries "Placemark", "Polygon", etc.

Fully agree, see top comment.


> On Jan. 27, 2013, 4:18 p.m., Torsten Rahn wrote:
> > src/QtMainWindow.cpp, line 481
> > <http://git.reviewboard.kde.org/r/108616/diff/1/?file=109370#file109370line481>
> >
> >     Where does that leave the "Small Screen" Category?

That's a side effect of the patch, The code refactors 2 methods into 1:
-    void  createInfoBoxesMenu();
-    void  createOnlineServicesMenu();
+    void  createPluginsMenus();


> On Jan. 27, 2013, 4:18 p.m., Torsten Rahn wrote:
> > src/QtMainWindow.cpp, line 396
> > <http://git.reviewboard.kde.org/r/108616/diff/1/?file=109370#file109370line396>
> >
> >     Where does that leave the "crosshairs" menu entry? If it ends up in the Tools section then it's in the wrong place. It's supposed to stay in the current place.


- Thibaut


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108616/#review26260
-----------------------------------------------------------


On Jan. 27, 2013, 5:36 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108616/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2013, 5:36 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Builds 3 menu lists with all the render plugins:
> - Info boxen
> - Online Services
> - Tools
> 
> More work needed to have atmosphere totally integrated.
> An alternative can be to use more RenderPlugins::renderTypes and separate further real tools, {sun/atmosphere/stars}, info boxes, online services
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.h bfe9ba7 
>   src/QtMainWindow.cpp 9224240 
> 
> Diff: http://git.reviewboard.kde.org/r/108616/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Render Plugins
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/renderplugins.jpg
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130127/34b43470/attachment.html>