[Marble-devel] Review Request 108616: QtMainWindow: unify Render Plugins Menus

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108616/#review26262
-----------------------------------------------------------


Sorry, but I'd rather like to see a follow-up patch that addresses the issues that I mentioned (menu entry position announcement etc.)-. before this patch goes into master. 

- Torsten Rahn


On Jan. 27, 2013, 3:52 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108616/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2013, 3:52 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Builds 3 menu lists with all the render plugins:
> - Info boxen
> - Online Services
> - Tools
> 
> More work needed to have atmosphere totally integrated.
> An alternative can be to use more RenderPlugins::renderTypes and separate further real tools, {sun/atmosphere/stars}, info boxes, online services
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.h bfe9ba7 
>   src/QtMainWindow.cpp 9224240 
> 
> Diff: http://git.reviewboard.kde.org/r/108616/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130127/15d259f9/attachment.html>