[Marble-devel] Review Request 108616: QtMainWindow: unify Render Plugins Menus

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108616/#review26260
-----------------------------------------------------------



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/108616/#comment19989>

    Where does that leave the "crosshairs" menu entry? If it ends up in the Tools section then it's in the wrong place. It's supposed to stay in the current place.



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/108616/#comment19993>

    I've always disliked having a "Tools" section: It has the danger of becoming a "dump everything else here" place (like the awful "Plugin" or "Tools" menus in other apps do).
    Instead plugins should announce themselves where they should go inside the menu (like discussed with Rene). An "Edit-mode" Plugin would for example announce that it would provide a "topLevel" Menu "Create" with menu entries "Placemark", "Polygon", etc.



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/108616/#comment19994>

    Where does that leave the "Small Screen" Category?


- Torsten Rahn


On Jan. 27, 2013, 3:52 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108616/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2013, 3:52 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Builds 3 menu lists with all the render plugins:
> - Info boxen
> - Online Services
> - Tools
> 
> More work needed to have atmosphere totally integrated.
> An alternative can be to use more RenderPlugins::renderTypes and separate further real tools, {sun/atmosphere/stars}, info boxes, online services
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.h bfe9ba7 
>   src/QtMainWindow.cpp 9224240 
> 
> Diff: http://git.reviewboard.kde.org/r/108616/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130127/abdd4ef1/attachment.html>