<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113904/">http://git.reviewboard.kde.org/r/113904/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Disclaimer: My review does not include a review of the actual code.
The license headers should be standardized.
Would be good to test this on Win/Mac as well. Does not need to be part of the review though.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113904/diff/2/?file=222218#file222218line4" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/astro/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">cmake_minimum_required</span><span class="p">(</span><span class="s">VERSION</span> <span class="s">2.4.0</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn't be needed here, we have it at the toplevel CMakeLists.txt</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113904/diff/2/?file=222218#file222218line102" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/astro/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">102</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">COMPILE_FLAGS</span> <span class="s2">"-DKML_LAZY_IMP"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-DKML_LAZY_IMP affects marble, but shouldn't be needed here</pre>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On December 3rd, 2013, 12:37 a.m. UTC, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Torsten Rahn and René Küttner.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2013, 12:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(1578335)</span></li>
<li>src/lib/astro/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astr2lib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astr2lib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/attlib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/attlib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/eclsolar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/eclsolar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/planetarySats.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/planetarySats.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/solarsystem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/solarsystem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113904/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>