[Marble-devel] Review Request 108636: Normalize SIGNAL and SLOT signatures

Dennis Nienhüser earthwings at gentoo.org
Sat Apr 6 16:02:05 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108636/#review30569
-----------------------------------------------------------


Yes, makes sense. Unfortunately the patch doesn't apply anymore (sorry for the long delay). Do you mind updating it? I'll make sure we'll have a quick review + commit afterwards.


- Dennis Nienhüser


On Jan. 27, 2013, 10:27 p.m., Dario Cambié wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108636/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2013, 10:27 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> According to [0] (and as reported in Krazy report [2]) the normalized call for SIGNALS and SLOTS should be preferred.
> Attached is a patch create with "normalize".
> 
> I understand that this breaks the coding convention of space around brackets ( )
> 
> [0] http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/
> [1] http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/marble/index.html
> 
> 
> Diffs
> -----
> 
>   examples/cpp/map-controls/main.cpp 32c2e18 
>   src/ControlView.cpp ec56d7f 
>   src/QtMainWindow.cpp 9224240 
>   src/lib/AbstractDataPlugin.cpp 529859d 
>   src/lib/AbstractDataPluginModel.cpp 7a136cd 
>   src/lib/AbstractFloatItem.cpp 658abab 
>   src/lib/AutoNavigation.cpp c2f12f8 
>   src/lib/BookmarkManagerDialog.cpp 1884f17 
>   src/lib/CurrentLocationWidget.cpp 6dd636f 
>   src/lib/DownloadQueueSet.cpp f53aafe 
>   src/lib/DownloadRegionDialog.cpp a1b98ca 
>   src/lib/EditBookmarkDialog.cpp e808ce3 
>   src/lib/ElevationModel.cpp c870d7f 
>   src/lib/ExternalEditorDialog.cpp a897bba 
>   src/lib/FileLoader.cpp 93d7db0 
>   src/lib/FileManager.cpp 135b4c3 
>   src/lib/FileStorageWatcher.cpp 1ab0e23 
>   src/lib/FileViewWidget.cpp 89604e6 
>   src/lib/GeoPolygon.cpp 49b2ac7 
>   src/lib/GoToDialog.cpp 793dafa 
>   src/lib/HttpDownloadManager.cpp 9a3a61a 
>   src/lib/HttpJob.cpp c2112c5 
>   src/lib/LatLonBoxWidget.cpp 6c8e4c4 
>   src/lib/LayerManager.cpp 26b0f34 
>   src/lib/LegendWidget.cpp 1b1a45f 
>   src/lib/MapThemeManager.cpp 7ce45ab 
>   src/lib/MapViewWidget.cpp da686ea 
>   src/lib/MapWizard.cpp 6eced45 
>   src/lib/MarbleAboutDialog.cpp effde0d 
>   src/lib/MarbleCacheSettingsWidget.cpp 8c0a139 
>   src/lib/MarbleClock.cpp 0fbbb28 
>   src/lib/MarbleControlBox.cpp 4bdedca 
>   src/lib/MarbleLegendBrowser.cpp fad7020 
>   src/lib/MarbleLineEdit.cpp 6dd3fb0 
>   src/lib/MarbleMap.cpp 92a20a7 
>   src/lib/MarbleModel.cpp c88ac58 
>   src/lib/MarbleNavigator.cpp 526780f 
>   src/lib/MarblePhysics.cpp e8c36ce 
>   src/lib/MarblePluginSettingsWidget.cpp 6f90579 
>   src/lib/MarbleRunnerManager.cpp 1b312b1 
>   src/lib/MarbleWidget.cpp 9a5833f 
>   src/lib/MarbleWidgetInputHandler.cpp 4d5f1f2 
>   src/lib/MarbleWidgetPopupMenu.cpp eb608be 
>   src/lib/NavigationWidget.cpp c00fe2d 
>   src/lib/NewstuffModel.cpp 9d386cd 
>   src/lib/PlacemarkLayout.cpp ae72de1 
>   src/lib/PositionTracking.cpp e2ffe44 
>   src/lib/QtMarbleConfigDialog.cpp 35b6459 
>   src/lib/RenderPlugin.cpp 18360cc 
>   src/lib/RunnerTask.cpp 56f0628 
>   src/lib/SearchInputWidget.cpp 7c0d550 
>   src/lib/SearchWidget.cpp 3f67bf4 
>   src/lib/SunControlWidget.cpp 10c50eb 
>   src/lib/TileCreatorDialog.cpp 254309b 
>   src/lib/TileLevelRangeWidget.cpp d0d68ca 
>   src/lib/TileLoader.cpp 900de67 
>   src/lib/TileScalingTextureMapper.cpp f2a0dd2 
>   src/lib/TimeControlWidget.cpp 1fadd67 
>   src/lib/TinyWebBrowser.cpp aeec6a2 
>   src/lib/VectorComposer.cpp 3674125 
>   src/lib/VectorTileMapper.cpp 098cc76 
>   src/lib/geodata/scene/GeoSceneDocument.cpp d332395 
>   src/lib/geodata/scene/GeoSceneGroup.cpp c547b72 
>   src/lib/geodata/scene/GeoSceneSettings.cpp 96f88d1 
>   src/lib/kdescendantsproxymodel.cpp fc0fe64 
>   src/lib/layers/GeometryLayer.cpp 90311d7 
>   src/lib/layers/PlacemarkLayer.cpp d6a1a33 
>   src/lib/layers/TextureLayer.cpp a5c978c 
>   src/lib/layers/VectorTileLayer.cpp b43ea9b 
>   src/lib/routing/AlternativeRoutesModel.cpp bd85dc3 
>   src/lib/routing/RouteAnnotator.cpp d3899e0 
>   src/lib/routing/RoutingInputWidget.cpp 98d019c 
>   src/lib/routing/RoutingLayer.cpp 9ba7e0d 
>   src/lib/routing/RoutingManager.cpp 62c203c 
>   src/lib/routing/RoutingModel.cpp eaf828a 
>   src/lib/routing/RoutingProfileSettingsDialog.cpp d904e35 
>   src/lib/routing/RoutingProfilesWidget.cpp c0b3e63 
>   src/lib/routing/RoutingWidget.cpp 84c4763 
>   src/lib/routing/SpeakersModel.cpp bf2e148 
>   src/marble_part.cpp c6ec40a 
>   src/plasmoid/worldclock.cpp e70fc61 
>   src/plugins/declarative/MarbleDeclarativeWidget.cpp 6e88012 
>   src/plugins/declarative/Tracking.cpp d5b0704 
>   src/plugins/render/aprs/AprsPlugin.cpp 9197494 
>   src/plugins/render/elevationprofilemarker/ElevationProfileMarker.cpp d84aaff 
>   src/plugins/render/measure/MeasureToolPlugin.cpp 85ef1eb 
>   src/plugins/render/satellites/SatellitesPlugin.cpp ed3e0af 
>   src/plugins/render/stars/StarsPlugin.cpp 28d8e9e 
>   src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp 4b36315 
>   src/plugins/runner/mapquest/MapQuestRunner.cpp 8ed1a97 
>   src/plugins/runner/monav/MonavConfigWidget.cpp d4bfca9 
>   src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp 9f1a0d7 
>   src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp ec8e809 
>   tests/MapViewWidgetTest.cpp 6a89182 
>   tests/MarbleRunnerManagerTest.cpp 05b42f7 
>   tests/PlacemarkPositionProviderPluginTest.cpp 31e7507 
>   tests/PositionTrackingTest.cpp 1950983 
>   tools/tilecreator-srtm2/tccore.cpp 8e9140d 
> 
> Diff: http://git.reviewboard.kde.org/r/108636/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran, checked for false-positive (i.e. no Q_PRIVATE_SLOT present).
> 
> 
> File Attachments
> ----------------
> 
> Attached as git-patch to ease testing
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/0001-Fix-normalized-SIGNAL-and-SLOT-signatures-as-in-http.patch
> 
> 
> Thanks,
> 
> Dario Cambié
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130406/cd4bcb10/attachment-0001.html>

More information about the Marble-devel mailing list