<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108636/">http://git.reviewboard.kde.org/r/108636/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, makes sense. Unfortunately the patch doesn't apply anymore (sorry for the long delay). Do you mind updating it? I'll make sure we'll have a quick review + commit afterwards.
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On January 27th, 2013, 10:27 p.m. UTC, Dario Cambié wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dario Cambié.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2013, 10:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to [0] (and as reported in Krazy report [2]) the normalized call for SIGNALS and SLOTS should be preferred.
Attached is a patch create with "normalize".
I understand that this breaks the coding convention of space around brackets ( )
[0] http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/
[1] http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/marble/index.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and ran, checked for false-positive (i.e. no Q_PRIVATE_SLOT present).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>examples/cpp/map-controls/main.cpp <span style="color: grey">(32c2e18)</span></li>
<li>src/ControlView.cpp <span style="color: grey">(ec56d7f)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(9224240)</span></li>
<li>src/lib/AbstractDataPlugin.cpp <span style="color: grey">(529859d)</span></li>
<li>src/lib/AbstractDataPluginModel.cpp <span style="color: grey">(7a136cd)</span></li>
<li>src/lib/AbstractFloatItem.cpp <span style="color: grey">(658abab)</span></li>
<li>src/lib/AutoNavigation.cpp <span style="color: grey">(c2f12f8)</span></li>
<li>src/lib/BookmarkManagerDialog.cpp <span style="color: grey">(1884f17)</span></li>
<li>src/lib/CurrentLocationWidget.cpp <span style="color: grey">(6dd636f)</span></li>
<li>src/lib/DownloadQueueSet.cpp <span style="color: grey">(f53aafe)</span></li>
<li>src/lib/DownloadRegionDialog.cpp <span style="color: grey">(a1b98ca)</span></li>
<li>src/lib/EditBookmarkDialog.cpp <span style="color: grey">(e808ce3)</span></li>
<li>src/lib/ElevationModel.cpp <span style="color: grey">(c870d7f)</span></li>
<li>src/lib/ExternalEditorDialog.cpp <span style="color: grey">(a897bba)</span></li>
<li>src/lib/FileLoader.cpp <span style="color: grey">(93d7db0)</span></li>
<li>src/lib/FileManager.cpp <span style="color: grey">(135b4c3)</span></li>
<li>src/lib/FileStorageWatcher.cpp <span style="color: grey">(1ab0e23)</span></li>
<li>src/lib/FileViewWidget.cpp <span style="color: grey">(89604e6)</span></li>
<li>src/lib/GeoPolygon.cpp <span style="color: grey">(49b2ac7)</span></li>
<li>src/lib/GoToDialog.cpp <span style="color: grey">(793dafa)</span></li>
<li>src/lib/HttpDownloadManager.cpp <span style="color: grey">(9a3a61a)</span></li>
<li>src/lib/HttpJob.cpp <span style="color: grey">(c2112c5)</span></li>
<li>src/lib/LatLonBoxWidget.cpp <span style="color: grey">(6c8e4c4)</span></li>
<li>src/lib/LayerManager.cpp <span style="color: grey">(26b0f34)</span></li>
<li>src/lib/LegendWidget.cpp <span style="color: grey">(1b1a45f)</span></li>
<li>src/lib/MapThemeManager.cpp <span style="color: grey">(7ce45ab)</span></li>
<li>src/lib/MapViewWidget.cpp <span style="color: grey">(da686ea)</span></li>
<li>src/lib/MapWizard.cpp <span style="color: grey">(6eced45)</span></li>
<li>src/lib/MarbleAboutDialog.cpp <span style="color: grey">(effde0d)</span></li>
<li>src/lib/MarbleCacheSettingsWidget.cpp <span style="color: grey">(8c0a139)</span></li>
<li>src/lib/MarbleClock.cpp <span style="color: grey">(0fbbb28)</span></li>
<li>src/lib/MarbleControlBox.cpp <span style="color: grey">(4bdedca)</span></li>
<li>src/lib/MarbleLegendBrowser.cpp <span style="color: grey">(fad7020)</span></li>
<li>src/lib/MarbleLineEdit.cpp <span style="color: grey">(6dd3fb0)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(92a20a7)</span></li>
<li>src/lib/MarbleModel.cpp <span style="color: grey">(c88ac58)</span></li>
<li>src/lib/MarbleNavigator.cpp <span style="color: grey">(526780f)</span></li>
<li>src/lib/MarblePhysics.cpp <span style="color: grey">(e8c36ce)</span></li>
<li>src/lib/MarblePluginSettingsWidget.cpp <span style="color: grey">(6f90579)</span></li>
<li>src/lib/MarbleRunnerManager.cpp <span style="color: grey">(1b312b1)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(9a5833f)</span></li>
<li>src/lib/MarbleWidgetInputHandler.cpp <span style="color: grey">(4d5f1f2)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(eb608be)</span></li>
<li>src/lib/NavigationWidget.cpp <span style="color: grey">(c00fe2d)</span></li>
<li>src/lib/NewstuffModel.cpp <span style="color: grey">(9d386cd)</span></li>
<li>src/lib/PlacemarkLayout.cpp <span style="color: grey">(ae72de1)</span></li>
<li>src/lib/PositionTracking.cpp <span style="color: grey">(e2ffe44)</span></li>
<li>src/lib/QtMarbleConfigDialog.cpp <span style="color: grey">(35b6459)</span></li>
<li>src/lib/RenderPlugin.cpp <span style="color: grey">(18360cc)</span></li>
<li>src/lib/RunnerTask.cpp <span style="color: grey">(56f0628)</span></li>
<li>src/lib/SearchInputWidget.cpp <span style="color: grey">(7c0d550)</span></li>
<li>src/lib/SearchWidget.cpp <span style="color: grey">(3f67bf4)</span></li>
<li>src/lib/SunControlWidget.cpp <span style="color: grey">(10c50eb)</span></li>
<li>src/lib/TileCreatorDialog.cpp <span style="color: grey">(254309b)</span></li>
<li>src/lib/TileLevelRangeWidget.cpp <span style="color: grey">(d0d68ca)</span></li>
<li>src/lib/TileLoader.cpp <span style="color: grey">(900de67)</span></li>
<li>src/lib/TileScalingTextureMapper.cpp <span style="color: grey">(f2a0dd2)</span></li>
<li>src/lib/TimeControlWidget.cpp <span style="color: grey">(1fadd67)</span></li>
<li>src/lib/TinyWebBrowser.cpp <span style="color: grey">(aeec6a2)</span></li>
<li>src/lib/VectorComposer.cpp <span style="color: grey">(3674125)</span></li>
<li>src/lib/VectorTileMapper.cpp <span style="color: grey">(098cc76)</span></li>
<li>src/lib/geodata/scene/GeoSceneDocument.cpp <span style="color: grey">(d332395)</span></li>
<li>src/lib/geodata/scene/GeoSceneGroup.cpp <span style="color: grey">(c547b72)</span></li>
<li>src/lib/geodata/scene/GeoSceneSettings.cpp <span style="color: grey">(96f88d1)</span></li>
<li>src/lib/kdescendantsproxymodel.cpp <span style="color: grey">(fc0fe64)</span></li>
<li>src/lib/layers/GeometryLayer.cpp <span style="color: grey">(90311d7)</span></li>
<li>src/lib/layers/PlacemarkLayer.cpp <span style="color: grey">(d6a1a33)</span></li>
<li>src/lib/layers/TextureLayer.cpp <span style="color: grey">(a5c978c)</span></li>
<li>src/lib/layers/VectorTileLayer.cpp <span style="color: grey">(b43ea9b)</span></li>
<li>src/lib/routing/AlternativeRoutesModel.cpp <span style="color: grey">(bd85dc3)</span></li>
<li>src/lib/routing/RouteAnnotator.cpp <span style="color: grey">(d3899e0)</span></li>
<li>src/lib/routing/RoutingInputWidget.cpp <span style="color: grey">(98d019c)</span></li>
<li>src/lib/routing/RoutingLayer.cpp <span style="color: grey">(9ba7e0d)</span></li>
<li>src/lib/routing/RoutingManager.cpp <span style="color: grey">(62c203c)</span></li>
<li>src/lib/routing/RoutingModel.cpp <span style="color: grey">(eaf828a)</span></li>
<li>src/lib/routing/RoutingProfileSettingsDialog.cpp <span style="color: grey">(d904e35)</span></li>
<li>src/lib/routing/RoutingProfilesWidget.cpp <span style="color: grey">(c0b3e63)</span></li>
<li>src/lib/routing/RoutingWidget.cpp <span style="color: grey">(84c4763)</span></li>
<li>src/lib/routing/SpeakersModel.cpp <span style="color: grey">(bf2e148)</span></li>
<li>src/marble_part.cpp <span style="color: grey">(c6ec40a)</span></li>
<li>src/plasmoid/worldclock.cpp <span style="color: grey">(e70fc61)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeWidget.cpp <span style="color: grey">(6e88012)</span></li>
<li>src/plugins/declarative/Tracking.cpp <span style="color: grey">(d5b0704)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(9197494)</span></li>
<li>src/plugins/render/elevationprofilemarker/ElevationProfileMarker.cpp <span style="color: grey">(d84aaff)</span></li>
<li>src/plugins/render/measure/MeasureToolPlugin.cpp <span style="color: grey">(85ef1eb)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.cpp <span style="color: grey">(ed3e0af)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(28d8e9e)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp <span style="color: grey">(4b36315)</span></li>
<li>src/plugins/runner/mapquest/MapQuestRunner.cpp <span style="color: grey">(8ed1a97)</span></li>
<li>src/plugins/runner/monav/MonavConfigWidget.cpp <span style="color: grey">(d4bfca9)</span></li>
<li>src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp <span style="color: grey">(9f1a0d7)</span></li>
<li>src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp <span style="color: grey">(ec8e809)</span></li>
<li>tests/MapViewWidgetTest.cpp <span style="color: grey">(6a89182)</span></li>
<li>tests/MarbleRunnerManagerTest.cpp <span style="color: grey">(05b42f7)</span></li>
<li>tests/PlacemarkPositionProviderPluginTest.cpp <span style="color: grey">(31e7507)</span></li>
<li>tests/PositionTrackingTest.cpp <span style="color: grey">(1950983)</span></li>
<li>tools/tilecreator-srtm2/tccore.cpp <span style="color: grey">(8e9140d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108636/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/0001-Fix-normalized-SIGNAL-and-SLOT-signatures-as-in-http.patch">Attached as git-patch to ease testing</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>