[Marble-devel] Review Request 108636: Normalize SIGNAL and SLOT signatures

[Dario Cambié]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108636/
-----------------------------------------------------------

(Updated April 6, 2013, 4:41 p.m.)


Review request for Marble.


Description
-------

According to [0] (and as reported in Krazy report [2]) the normalized call for SIGNALS and SLOTS should be preferred.
Attached is a patch create with "normalize".

I understand that this breaks the coding convention of space around brackets ( )

[0] http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/
[1] http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/marble/index.html


Diffs (updated)
-----

  examples/cpp/map-controls/main.cpp 32c2e18 
  src/ControlView.cpp 096ec0e 
  src/QtMainWindow.cpp a081df0 
  src/lib/AbstractDataPlugin.cpp a81a7d2 
  src/lib/AbstractDataPluginModel.cpp 32a71ba 
  src/lib/AbstractFloatItem.cpp 2f7052e 
  src/lib/AutoNavigation.cpp c2f12f8 
  src/lib/BookmarkManagerDialog.cpp 1884f17 
  src/lib/CurrentLocationWidget.cpp 6dd636f 
  src/lib/DownloadQueueSet.cpp f53aafe 
  src/lib/DownloadRegionDialog.cpp 6a929a1 
  src/lib/EditBookmarkDialog.cpp e808ce3 
  src/lib/ElevationModel.cpp c870d7f 
  src/lib/ExternalEditorDialog.cpp a897bba 
  src/lib/FileLoader.cpp 93d7db0 
  src/lib/FileManager.cpp 135b4c3 
  src/lib/FileStorageWatcher.cpp 1ab0e23 
  src/lib/FileViewWidget.cpp 89604e6 
  src/lib/GeoPolygon.cpp efd8e9b 
  src/lib/GoToDialog.cpp 793dafa 
  src/lib/HttpDownloadManager.cpp a88a7ec 
  src/lib/HttpJob.cpp c2112c5 
  src/lib/LatLonBoxWidget.cpp 6c8e4c4 
  src/lib/LayerManager.cpp 26b0f34 
  src/lib/LegendWidget.cpp 1b1a45f 
  src/lib/MapThemeManager.cpp ce9c962 
  src/lib/MapViewWidget.cpp e341552 
  src/lib/MapWizard.cpp 6eced45 
  src/lib/MarbleAboutDialog.cpp effde0d 
  src/lib/MarbleCacheSettingsWidget.cpp 8c0a139 
  src/lib/MarbleClock.cpp 0fbbb28 
  src/lib/MarbleControlBox.cpp 4bdedca 
  src/lib/MarbleLegendBrowser.cpp 61a8ce1 
  src/lib/MarbleLineEdit.cpp 6dd3fb0 
  src/lib/MarbleMap.cpp 2ca90a9 
  src/lib/MarbleModel.cpp 28b090e 
  src/lib/MarbleNavigator.cpp 526780f 
  src/lib/MarblePhysics.cpp e8c36ce 
  src/lib/MarblePluginSettingsWidget.cpp 6f90579 
  src/lib/MarbleRunnerManager.cpp 5ec9a81 
  src/lib/MarbleWidget.cpp f7b17a9 
  src/lib/MarbleWidgetInputHandler.cpp 4d5f1f2 
  src/lib/MarbleWidgetPopupMenu.cpp 1eca33a 
  src/lib/NavigationWidget.cpp c00fe2d 
  src/lib/NewstuffModel.cpp 9d386cd 
  src/lib/PlacemarkLayout.cpp 6d6f9e2 
  src/lib/PositionTracking.cpp e2ffe44 
  src/lib/QtMarbleConfigDialog.cpp 35b6459 
  src/lib/RenderPlugin.cpp 1f98ce9 
  src/lib/RunnerTask.cpp 8a584a3 
  src/lib/SearchInputWidget.cpp 7c0d550 
  src/lib/SearchWidget.cpp 3f67bf4 
  src/lib/SunControlWidget.cpp 10c50eb 
  src/lib/TileCreatorDialog.cpp 254309b 
  src/lib/TileLevelRangeWidget.cpp d0d68ca 
  src/lib/TileLoader.cpp 61f2f8a 
  src/lib/TileScalingTextureMapper.cpp e787285 
  src/lib/TimeControlWidget.cpp 1fadd67 
  src/lib/TinyWebBrowser.cpp aeec6a2 
  src/lib/VectorComposer.cpp 3674125 
  src/lib/VectorTileMapper.cpp 6f338a9 
  src/lib/geodata/scene/GeoSceneDocument.cpp d332395 
  src/lib/geodata/scene/GeoSceneGroup.cpp c547b72 
  src/lib/geodata/scene/GeoSceneSettings.cpp 96f88d1 
  src/lib/kdescendantsproxymodel.cpp fc0fe64 
  src/lib/layers/GeometryLayer.cpp a9aa23c 
  src/lib/layers/PlacemarkLayer.cpp d6a1a33 
  src/lib/layers/TextureLayer.cpp 6960c84 
  src/lib/layers/VectorTileLayer.cpp 3a44069 
  src/lib/routing/AlternativeRoutesModel.cpp d29ddff 
  src/lib/routing/RoutingInputWidget.cpp 98d019c 
  src/lib/routing/RoutingLayer.cpp 29a2cc0 
  src/lib/routing/RoutingManager.cpp 7148a44 
  src/lib/routing/RoutingModel.cpp eaf828a 
  src/lib/routing/RoutingProfileSettingsDialog.cpp d904e35 
  src/lib/routing/RoutingProfilesWidget.cpp b0aecdd 
  src/lib/routing/RoutingWidget.cpp ebf17db 
  src/lib/routing/SpeakersModel.cpp bf2e148 
  src/marble_part.cpp 64499fe 
  src/plasmoid/worldclock.cpp 7cae4d4 
  src/plugins/declarative/MarbleDeclarativeWidget.cpp 361c960 
  src/plugins/declarative/Tracking.cpp f5941a1 
  src/plugins/render/aprs/AprsPlugin.cpp 4f7a7be 
  src/plugins/render/atmosphere/AtmospherePlugin.cpp a644cc5 
  src/plugins/render/elevationprofilemarker/ElevationProfileMarker.cpp d84aaff 
  src/plugins/render/measure/MeasureToolPlugin.cpp 85ef1eb 
  src/plugins/render/satellites/SatellitesPlugin.cpp 5858cfd 
  src/plugins/render/stars/StarsPlugin.cpp 3c8ba02 
  src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp 59f072a 
  src/plugins/runner/mapquest/MapQuestRunner.cpp 8ed1a97 
  src/plugins/runner/monav/MonavConfigWidget.cpp d4bfca9 
  src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp 9f1a0d7 
  src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp ec8e809 
  tests/AbstractDataPluginModelTest.cpp 8bc2b33 
  tests/MapViewWidgetTest.cpp 6a89182 
  tests/MarbleRunnerManagerTest.cpp 05b42f7 
  tests/PlacemarkPositionProviderPluginTest.cpp 31e7507 
  tests/PositionTrackingTest.cpp 1950983 
  tools/tilecreator-srtm2/tccore.cpp 8e9140d 

Diff: http://git.reviewboard.kde.org/r/108636/diff/


Testing
-------

Compiled and ran, checked for false-positive (i.e. no Q_PRIVATE_SLOT present).


File Attachments (updated)
----------------

git format-patch diff
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/06/0001-Fix-normalized-SIGNAL-and-SLOT-signatures-as-in.patch


Thanks,

Dario Cambié

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130406/7cdcc799/attachment.html>