[Marble-devel] Review Request: Have GeoDataLatLonBox(void) create empty boxes
Commit Hook
null at kde.org
Fri May 25 08:52:14 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105038/#review14155
-----------------------------------------------------------
This review has been submitted with commit d641bde789a91ca5a296cecebc6fd39f99a2425d by Dennis Nienhüser to branch master.
- Commit Hook
On May 24, 2012, 7:43 p.m., Dennis Nienhüser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105038/
> -----------------------------------------------------------
>
> (Updated May 24, 2012, 7:43 p.m.)
>
>
> Review request for Marble.
>
>
> Description
> -------
>
> Changes the default ctor to create an empty sized box instead of one spanning the entire globe. See https://bugs.kde.org/show_bug.cgi?id=299959 for details.
>
>
> This addresses bug 299959.
> http://bugs.kde.org/show_bug.cgi?id=299959
>
>
> Diffs
> -----
>
> src/lib/geodata/data/GeoDataLatLonBox.h 4932c3a
> src/lib/geodata/data/GeoDataLatLonBox.cpp 96ae95f
> tests/TestGeoDataLatLonAltBox.cpp 16f09dc
>
> Diff: http://git.reviewboard.kde.org/r/105038/diff/
>
>
> Testing
> -------
>
> The patch contains some unit tests, the existing ones still work.
>
> From running Marble I didn't notice anything wrong in particular.
>
>
> Thanks,
>
> Dennis Nienhüser
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120525/bba2003b/attachment.html>
More information about the Marble-devel
mailing list