[Marble-devel] Review Request: Have GeoDataLatLonBox(void) create empty boxes

Dennis Nienhüser earthwings at gentoo.org
Thu May 24 19:43:54 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated May 24, 2012, 7:43 p.m.)

Review request for Marble.


The updated patch handles the special case that null boxes do not intersect null boxes.


Changes the default ctor to create an empty sized box instead of one spanning the entire globe. See https://bugs.kde.org/show_bug.cgi?id=299959 for details.

This addresses bug 299959.

Diffs (updated)

  src/lib/geodata/data/GeoDataLatLonBox.h 4932c3a 
  src/lib/geodata/data/GeoDataLatLonBox.cpp 96ae95f 
  tests/TestGeoDataLatLonAltBox.cpp 16f09dc 

Diff: http://git.reviewboard.kde.org/r/105038/diff/


The patch contains some unit tests, the existing ones still work.

>From running Marble I didn't notice anything wrong in particular.


Dennis Nienhüser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120524/273c5f33/attachment-0001.html>

More information about the Marble-devel mailing list