[Marble-devel] Review Request: Task 3 from Trello: separate IDL, poles and lineStringToPolygon into CylindricalProjections

Cezar Mocan mocancezar at gmail.com
Sun Jun 24 12:49:33 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated June 24, 2012, 12:49 p.m.)

Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.


Small change in AbstractProjection.h


Separate AbstractProjectionPrivate::lineStringToPolygon into CylindricalProjectionPrivate::lineStringToPolygon and SphericalProjectionPrivate::lineStringToPolygon in order to get rid of the corner cases. 
It is not final, right now I have just commented the lines which need to be removed in my opinion. Also, I would need some advice regarding what else needs to be deleted from CylindricalProjectionPrivate::lineStringToPolygon. 

Diffs (updated)

  src/lib/Projections/AbstractProjection.h 46f0aa0 

Diff: http://git.reviewboard.kde.org/r/105261/diff/


Marble seems to work properly with all 3 projections after applying the patch. MercatorProjectionTest passes all the 5 tests. How else could I test the change?


Cezar Mocan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120624/bd31558d/attachment.html>

More information about the Marble-devel mailing list