[Marble-devel] Review Request: Task 3 from Trello: separate IDL, poles and lineStringToPolygon into CylindricalProjections

Cezar Mocan mocancezar at gmail.com
Sun Jun 24 12:16:09 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated June 24, 2012, 12:16 p.m.)

Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.


In the previous diff the sharing of the d-pointer was not done properly, so Marble was not working as it should have (problems at loading KML files, for example). Now it is fixed and tested. 


Separate AbstractProjectionPrivate::lineStringToPolygon into CylindricalProjectionPrivate::lineStringToPolygon and SphericalProjectionPrivate::lineStringToPolygon in order to get rid of the corner cases. 
It is not final, right now I have just commented the lines which need to be removed in my opinion. Also, I would need some advice regarding what else needs to be deleted from CylindricalProjectionPrivate::lineStringToPolygon. 

Diffs (updated)

  src/lib/Projections/AbstractProjection.h 46f0aa0 
  src/lib/Projections/AbstractProjection.cpp 92ae3dd 
  src/lib/Projections/AbstractProjection_p.h d8f6063 
  src/lib/Projections/CylindricalProjection.h affd1e6 
  src/lib/Projections/CylindricalProjection.cpp c103a68 
  src/lib/Projections/CylindricalProjection_p.h PRE-CREATION 
  src/lib/Projections/EquirectProjection.h dbd990e 
  src/lib/Projections/EquirectProjection.cpp 4566d4f 
  src/lib/Projections/MercatorProjection.h 30fbb0a 
  src/lib/Projections/MercatorProjection.cpp cc21206 
  src/lib/Projections/SphericalProjection.h 75ea797 
  src/lib/Projections/SphericalProjection.cpp 0978af4 
  src/lib/Projections/SphericalProjection_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105261/diff/


Marble seems to work properly with all 3 projections after applying the patch. MercatorProjectionTest passes all the 5 tests. How else could I test the change?


Cezar Mocan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120624/b90f1897/attachment.html>

More information about the Marble-devel mailing list