<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105261/">http://git.reviewboard.kde.org/r/105261/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.</div>
<div>By Cezar Mocan.</div>
<p style="color: grey;"><i>Updated June 24, 2012, 12:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the previous diff the sharing of the d-pointer was not done properly, so Marble was not working as it should have (problems at loading KML files, for example). Now it is fixed and tested. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Separate AbstractProjectionPrivate::lineStringToPolygon into CylindricalProjectionPrivate::lineStringToPolygon and SphericalProjectionPrivate::lineStringToPolygon in order to get rid of the corner cases.
It is not final, right now I have just commented the lines which need to be removed in my opinion. Also, I would need some advice regarding what else needs to be deleted from CylindricalProjectionPrivate::lineStringToPolygon. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marble seems to work properly with all 3 projections after applying the patch. MercatorProjectionTest passes all the 5 tests. How else could I test the change?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/Projections/AbstractProjection.h <span style="color: grey">(46f0aa0)</span></li>
<li>src/lib/Projections/AbstractProjection.cpp <span style="color: grey">(92ae3dd)</span></li>
<li>src/lib/Projections/AbstractProjection_p.h <span style="color: grey">(d8f6063)</span></li>
<li>src/lib/Projections/CylindricalProjection.h <span style="color: grey">(affd1e6)</span></li>
<li>src/lib/Projections/CylindricalProjection.cpp <span style="color: grey">(c103a68)</span></li>
<li>src/lib/Projections/CylindricalProjection_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/Projections/EquirectProjection.h <span style="color: grey">(dbd990e)</span></li>
<li>src/lib/Projections/EquirectProjection.cpp <span style="color: grey">(4566d4f)</span></li>
<li>src/lib/Projections/MercatorProjection.h <span style="color: grey">(30fbb0a)</span></li>
<li>src/lib/Projections/MercatorProjection.cpp <span style="color: grey">(cc21206)</span></li>
<li>src/lib/Projections/SphericalProjection.h <span style="color: grey">(75ea797)</span></li>
<li>src/lib/Projections/SphericalProjection.cpp <span style="color: grey">(0978af4)</span></li>
<li>src/lib/Projections/SphericalProjection_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105261/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>