[Marble-devel] Review Request: AltitudeModel, altitude-profile plugin, srtm2 tilecreator

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102637/#review6860
-----------------------------------------------------------



src/lib/AltitudeModel.h
<http://git.reviewboard.kde.org/r/102637/#comment6099>

    This signal should get a more expressive name, such as "updateAvailable()". Perhaps it could even pass the affected bbox as a parameter.



src/plugins/render/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102637/#comment6098>

    looks like this should be changed to altitude-profile



src/plugins/render/altitude-profile/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102637/#comment6094>

    isn't ${CMAKE_CURRENT_SOURCE_DIR} enough?



src/plugins/render/altitude-profile/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102637/#comment6095>

    souldn't this be ${CMAKE_CURRENT_BINARY_DIR}?



tools/tilecreator-srtm2/main.cpp
<http://git.reviewboard.kde.org/r/102637/#comment6097>

    the copyright statement looks incorrect or incomplete



tools/tilecreator-srtm2/tccore.h
<http://git.reviewboard.kde.org/r/102637/#comment6096>

    the copyright statement looks incorrect or incomplete


- Bernhard Beschow


On Sept. 21, 2011, 7:36 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102637/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2011, 7:36 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch adds an AltidudeModel that can be used to get the altitude/elevation of a coordinate. The altitude-profile plugin uses that to generate a profile for a route and calculate some statistics.
> The altitude-profile will be replaced/merged with elevationprofile plugin that was developed in parallel.
> 
> The other important part are the tiles. I used the existing TileCreator, refactored it to be more flexible and made a binary that creates the needed png tiles from the nasa srtm files. This takes a loong time, just as the upload to files.kde.org that is still running.
> 
> Please review my changes especially also those to TileCreator.
> To review this you can also use the altitude branch in the marble repository; that contains full history (which might be useful)
> 
> In the attached screenshot you can see the altitude-profile float widget (red line) and the elevationprofile float widget (black line) - not included in this request.
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 6f16a74 
>   data/maps/earth/srtm2/0/000000/000000_000000.png PRE-CREATION 
>   data/maps/earth/srtm2/0/000000/000000_000001.png PRE-CREATION 
>   data/maps/earth/srtm2/srtm2.dgml PRE-CREATION 
>   src/lib/AltitudeModel.h PRE-CREATION 
>   src/lib/AltitudeModel.cpp PRE-CREATION 
>   src/lib/CMakeLists.txt 328db8f 
>   src/lib/MarbleModel.h 0e4f2c8 
>   src/lib/MarbleModel.cpp c1588f8 
>   src/lib/TileCreator.h 5b58158 
>   src/lib/TileCreator.cpp 0ffa155 
>   src/lib/routing/AlternativeRoutesModel.h 945a745 
>   src/marble.qrc c92a412 
>   src/plugins/render/CMakeLists.txt 37075b3 
>   src/plugins/render/altitude-profile/AltitudeProfile.h PRE-CREATION 
>   src/plugins/render/altitude-profile/AltitudeProfile.cpp PRE-CREATION 
>   src/plugins/render/altitude-profile/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/altitude-profile/PlotPoint.h PRE-CREATION 
>   src/plugins/render/altitude-profile/PlotPoint.cpp PRE-CREATION 
>   src/plugins/render/altitude-profile/PlotWidget.h PRE-CREATION 
>   src/plugins/render/altitude-profile/PlotWidget.cpp PRE-CREATION 
>   tools/tilecreator-srtm2/CMakeLists.txt PRE-CREATION 
>   tools/tilecreator-srtm2/main.cpp PRE-CREATION 
>   tools/tilecreator-srtm2/tccore.h PRE-CREATION 
>   tools/tilecreator-srtm2/tccore.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102637/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> altitude profile in action
>   http://git.reviewboard.kde.org/r/102637/s/263/
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110927/8672eccb/attachment.html>