[Marble-devel] Review Request: AltitudeModel, altitude-profile plugin, srtm2 tilecreator

[Konrad Enzensberger]

Hi,

will AltitudeModel, TileCreator modification and all related code be merged to git master soon?

br, konrad
  ----- Original Message ----- 
  From: Niko Sams 
  To: Niko Sams ; Marble ; Dennis Nienhüser 
  Sent: Wednesday, September 21, 2011 9:36 PM
  Subject: Re: [Marble-devel] Review Request: AltitudeModel,altitude-profile plugin, srtm2 tilecreator


        This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102637/  

        Review request for Marble.
        By Niko Sams.
        Updated Sept. 21, 2011, 7:36 p.m.

        Changes
fix issues pointed out by Dennis 

        Description 
This patch adds an AltidudeModel that can be used to get the altitude/elevation of a coordinate. The altitude-profile plugin uses that to generate a profile for a route and calculate some statistics.
The altitude-profile will be replaced/merged with elevationprofile plugin that was developed in parallel.

The other important part are the tiles. I used the existing TileCreator, refactored it to be more flexible and made a binary that creates the needed png tiles from the nasa srtm files. This takes a loong time, just as the upload to files.kde.org that is still running.

Please review my changes especially also those to TileCreator.
To review this you can also use the altitude branch in the marble repository; that contains full history (which might be useful)

In the attached screenshot you can see the altitude-profile float widget (red line) and the elevationprofile float widget (black line) - not included in this request. 

        Diffs (updated)
          a.. data/CMakeLists.txt (6f16a74) 
          b.. data/maps/earth/srtm2/0/000000/000000_000000.png (PRE-CREATION) 
          c.. data/maps/earth/srtm2/0/000000/000000_000001.png (PRE-CREATION) 
          d.. data/maps/earth/srtm2/srtm2.dgml (PRE-CREATION) 
          e.. src/lib/AltitudeModel.h (PRE-CREATION) 
          f.. src/lib/AltitudeModel.cpp (PRE-CREATION) 
          g.. src/lib/CMakeLists.txt (328db8f) 
          h.. src/lib/MarbleModel.h (0e4f2c8) 
          i.. src/lib/MarbleModel.cpp (c1588f8) 
          j.. src/lib/TileCreator.h (5b58158) 
          k.. src/lib/TileCreator.cpp (0ffa155) 
          l.. src/lib/routing/AlternativeRoutesModel.h (945a745) 
          m.. src/marble.qrc (c92a412) 
          n.. src/plugins/render/CMakeLists.txt (37075b3) 
          o.. src/plugins/render/altitude-profile/AltitudeProfile.h (PRE-CREATION) 
          p.. src/plugins/render/altitude-profile/AltitudeProfile.cpp (PRE-CREATION) 
          q.. src/plugins/render/altitude-profile/CMakeLists.txt (PRE-CREATION) 
          r.. src/plugins/render/altitude-profile/PlotPoint.h (PRE-CREATION) 
          s.. src/plugins/render/altitude-profile/PlotPoint.cpp (PRE-CREATION) 
          t.. src/plugins/render/altitude-profile/PlotWidget.h (PRE-CREATION) 
          u.. src/plugins/render/altitude-profile/PlotWidget.cpp (PRE-CREATION) 
          v.. tools/tilecreator-srtm2/CMakeLists.txt (PRE-CREATION) 
          w.. tools/tilecreator-srtm2/main.cpp (PRE-CREATION) 
          x.. tools/tilecreator-srtm2/tccore.h (PRE-CREATION) 
          y.. tools/tilecreator-srtm2/tccore.cpp (PRE-CREATION) 
        View Diff

        Screenshots 
          



------------------------------------------------------------------------------


  _______________________________________________
  Marble-devel mailing list
  Marble-devel at kde.org
  https://mail.kde.org/mailman/listinfo/marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110923/b7976fd9/attachment.html>