<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=utf-8" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.19120">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>Hi,</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>will AltitudeModel, TileCreator modification and
all related code be merged to git master soon?</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>br, konrad</FONT></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=niko.sams@gmail.com href="mailto:niko.sams@gmail.com">Niko Sams</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=niko.sams@gmail.com
href="mailto:niko.sams@gmail.com">Niko Sams</A> ; <A
title=marble-devel@kde.org href="mailto:marble-devel@kde.org">Marble</A> ; <A
title=earthwings@gentoo.org href="mailto:earthwings@gentoo.org">Dennis
Nienhüser</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Wednesday, September 21, 2011 9:36
PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [Marble-devel] Review
Request: AltitudeModel,altitude-profile plugin, srtm2 tilecreator</DIV>
<DIV><BR></DIV>
<DIV style="FONT-FAMILY: Verdana, Arial, Helvetica, Sans-Serif">
<TABLE
style="BORDER-BOTTOM: #c9c399 1px solid; BORDER-LEFT: #c9c399 1px solid; BORDER-TOP: #c9c399 1px solid; BORDER-RIGHT: #c9c399 1px solid"
cellPadding=8 width="100%" bgColor=#f9f3c9>
<TBODY>
<TR>
<TD>This is an automatically generated e-mail. To reply, visit: <A
href="http://git.reviewboard.kde.org/r/102637/">http://git.reviewboard.kde.org/r/102637/</A>
</TD></TR></TBODY></TABLE><BR>
<TABLE
style="BACKGROUND-IMAGE: url(http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png); BORDER-BOTTOM: black 1px solid; BORDER-LEFT: black 1px solid; BACKGROUND-REPEAT: repeat-x; BACKGROUND-POSITION: left top; BORDER-TOP: black 1px solid; BORDER-RIGHT: black 1px solid"
cellSpacing=0 cellPadding=8 width="100%" bgColor=#fefadf>
<TBODY>
<TR>
<TD>
<DIV>Review request for Marble.</DIV>
<DIV>By Niko Sams.</DIV>
<P style="COLOR: grey"><I>Updated Sept. 21, 2011, 7:36 p.m.</I></P>
<H1
style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Changes</H1>
<TABLE
style="BORDER-BOTTOM: #b8b5a0 1px solid; BORDER-LEFT: #b8b5a0 1px solid; BORDER-TOP: #b8b5a0 1px solid; BORDER-RIGHT: #b8b5a0 1px solid"
cellSpacing=0 cellPadding=10 width="100%" bgColor=#ffffff>
<TBODY>
<TR>
<TD><PRE style="PADDING-BOTTOM: 0px; MARGIN: 0px; PADDING-LEFT: 0px; PADDING-RIGHT: 0px; WORD-WRAP: break-word; PADDING-TOP: 0px">fix issues pointed out by Dennis</PRE></TD></TR></TBODY></TABLE>
<H1
style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Description
</H1>
<TABLE
style="BORDER-BOTTOM: #b8b5a0 1px solid; BORDER-LEFT: #b8b5a0 1px solid; BORDER-TOP: #b8b5a0 1px solid; BORDER-RIGHT: #b8b5a0 1px solid"
cellSpacing=0 cellPadding=10 width="100%" bgColor=#ffffff>
<TBODY>
<TR>
<TD><PRE style="PADDING-BOTTOM: 0px; MARGIN: 0px; PADDING-LEFT: 0px; PADDING-RIGHT: 0px; WORD-WRAP: break-word; PADDING-TOP: 0px">This patch adds an AltidudeModel that can be used to get the altitude/elevation of a coordinate. The altitude-profile plugin uses that to generate a profile for a route and calculate some statistics.
The altitude-profile will be replaced/merged with elevationprofile plugin that was developed in parallel.
The other important part are the tiles. I used the existing TileCreator, refactored it to be more flexible and made a binary that creates the needed png tiles from the nasa srtm files. This takes a loong time, just as the upload to files.kde.org that is still running.
Please review my changes especially also those to TileCreator.
To review this you can also use the altitude branch in the marble repository; that contains full history (which might be useful)
In the attached screenshot you can see the altitude-profile float widget (red line) and the elevationprofile float widget (black line) - not included in this request.</PRE></TD></TR></TBODY></TABLE>
<H1 style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Diffs</B>
(updated)</H1>
<UL style="PADDING-LEFT: 0px; MARGIN-LEFT: 3em">
<LI>data/CMakeLists.txt <SPAN style="COLOR: grey">(6f16a74)</SPAN>
<LI>data/maps/earth/srtm2/0/000000/000000_000000.png <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>data/maps/earth/srtm2/0/000000/000000_000001.png <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>data/maps/earth/srtm2/srtm2.dgml <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/lib/AltitudeModel.h <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/lib/AltitudeModel.cpp <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/lib/CMakeLists.txt <SPAN style="COLOR: grey">(328db8f)</SPAN>
<LI>src/lib/MarbleModel.h <SPAN style="COLOR: grey">(0e4f2c8)</SPAN>
<LI>src/lib/MarbleModel.cpp <SPAN style="COLOR: grey">(c1588f8)</SPAN>
<LI>src/lib/TileCreator.h <SPAN style="COLOR: grey">(5b58158)</SPAN>
<LI>src/lib/TileCreator.cpp <SPAN style="COLOR: grey">(0ffa155)</SPAN>
<LI>src/lib/routing/AlternativeRoutesModel.h <SPAN
style="COLOR: grey">(945a745)</SPAN>
<LI>src/marble.qrc <SPAN style="COLOR: grey">(c92a412)</SPAN>
<LI>src/plugins/render/CMakeLists.txt <SPAN
style="COLOR: grey">(37075b3)</SPAN>
<LI>src/plugins/render/altitude-profile/AltitudeProfile.h <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/plugins/render/altitude-profile/AltitudeProfile.cpp <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/plugins/render/altitude-profile/CMakeLists.txt <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/plugins/render/altitude-profile/PlotPoint.h <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/plugins/render/altitude-profile/PlotPoint.cpp <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/plugins/render/altitude-profile/PlotWidget.h <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>src/plugins/render/altitude-profile/PlotWidget.cpp <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>tools/tilecreator-srtm2/CMakeLists.txt <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>tools/tilecreator-srtm2/main.cpp <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>tools/tilecreator-srtm2/tccore.h <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN>
<LI>tools/tilecreator-srtm2/tccore.cpp <SPAN
style="COLOR: grey">(PRE-CREATION)</SPAN> </LI></UL>
<P><A style="MARGIN-LEFT: 3em"
href="http://git.reviewboard.kde.org/r/102637/diff/">View Diff</A></P>
<H1
style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Screenshots
</H1>
<DIV><A href="http://git.reviewboard.kde.org/r/102637/s/263/"><IMG
style="BORDER-BOTTOM: black 1px solid; BORDER-LEFT: black 1px solid; BORDER-TOP: black 1px solid; BORDER-RIGHT: black 1px solid"
alt="altitude profile in action"
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/16/marble-altitude-profile_400x100.png"></A>
</DIV></TD></TR></TBODY></TABLE></DIV>
<P>
<HR>
<P></P>_______________________________________________<BR>Marble-devel mailing
list<BR>Marble-devel@kde.org<BR>https://mail.kde.org/mailman/listinfo/marble-devel<BR></BLOCKQUOTE></BODY></HTML>