[Marble-devel] Review of "Plasma Runner" and "GeoDataCoordinates::fromString(...) fix" before Hard Feature freeze?

Friedrich W. H. Kossebau kossebau at kde.org
Mon Nov 7 20:13:28 UTC 2011


Dimanche, le 6 novembre 2011, à 21:54, Torsten Rahn a écrit:
> Hi,
> 
> > What, not obvious? ;)
> 
> Well, you could argue it's obvious to many: it's obvious to you, the
> compiler and the linker.

:)

> > Added some API dox where I think it will be helpfull,
> 
> Thanks. I think this will help others. And it made a few things more clear
> to me.

Right, caught me being lazy.

> > Wait a bit until when?
> 
> Christmas. ;-)

I was going to ask which one... ;)

> > Also asked once on plasma-devel (well, as part of bigger email), but
> > noone over there seems to have found the time to do some review. Still
> > should be quite okay.
> > And works fine for me all the time :)
> 
> I'd say since  you did everything to allow for proper review, since you
> tested it well and since you seem to feel confident about it,
> please just commit your patch right now!

Done, thanks!

Hopefully will add more for the next release, still some itches not scratched 
:)

Cheers
Friedrich


More information about the Marble-devel mailing list