[Marble-devel] Review of "Plasma Runner" and "GeoDataCoordinates::fromString(...) fix" before Hard Feature freeze?

Torsten Rahn tackat at t-online.de
Sun Nov 6 20:54:24 UTC 2011


Hi,

> What, not obvious? ;) 

Well, you could argue it's obvious to many: it's obvious to you, the compiler 
and the linker. 

> Added some API dox where I think it will be helpfull,

Thanks. I think this will help others. And it made a few things more clear to 
me.

> Wait a bit until when?

Christmas. ;-)

> Also asked once on plasma-devel (well, as part of bigger email), but noone
> over there seems to have found the time to do some review. Still should be
> quite okay.
> And works fine for me all the time :)

I'd say since  you did everything to allow for proper review, since you tested 
it well and since you seem to feel confident about it,
please just commit your patch right now!

BR,
Torsten

> > > Would be happy to have them in Marble 1.3.
> > 
> > I'd be happy, too :-)
> 
> Good to read :)
> 
> Cheers
> Friedrich


More information about the Marble-devel mailing list