[Marble-devel] Review Request: Fix GeoDataCoordinates::fromString(...)

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103000/
-----------------------------------------------------------

(Updated Nov. 4, 2011, 8:55 p.m.)


Review request for Marble.


Changes
-------

Small update:
* lon lat order in code
* accept two ' chars as the seconds symbol (seen in real life)


Description
-------

Fixes GeoDataCoordinates::fromString(...) by a rewrite of parsing code.
Turned parsing code into a parser class, named LatLonParser.

Supports parsing of D, DM, and DMS:
* last unit can be in floating point precision
* directions can be in local language, fallback to english if not matching
* accepts plain ASCII chars ' " as well as chars ? (PRIME) and ? (DOUBLE PRIME).


Diffs (updated)
-----

  src/lib/geodata/data/GeoDataCoordinates.cpp a0a2436 
  tests/unittest_geodatacoordinates.cpp 10f2d94 

Diff: http://git.reviewboard.kde.org/r/103000/diff/diff


Testing
-------

Patch adds 3 new unit tests which all pass.
Also entered coordinates in lots of different formats to my Plasma Marble Runner, worked fine.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111104/099a09ad/attachment.html>