[Marble-devel] Review Request: Search option in the 'Go To...' dialog

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101261/
-----------------------------------------------------------

Review request for Marble.


Summary
-------

Adds a search input field to the 'Go To...' dialog used in the mobile application. It brings the same search feature the desktop application has in the Navigation tab, i.e. a search querying the search runners and displaying results in the list view. Given that it relies on existing features, the code is pretty straightforward. I'm mainly interested in feedback regarding usability of the dialog and have attached three screenshots showing the new dialog on the N900.

I'd like the user to recognize that the dialog has two modes. One where you select a place to go to from a set of predefined places (bookmarks, waypoints of the route). The other one where you search for a place. While I'd like to avoid using tabs or more than one window, I'd also like to avoid merging both modes as that would easily be understood as the search feature working as a filter on the bookmarks. Therefore I added the push button to switch between both modes.


Diffs
-----

  src/lib/GoToDialog.h 62c358f 
  src/lib/GoToDialog.cpp caeff72 
  src/lib/GoToDialog.ui f0756a3 

Diff: http://git.reviewboard.kde.org/r/101261/diff


Testing
-------

Desktop and N900.


Screenshots
-----------

goto-dialog-initial-view
  http://git.reviewboard.kde.org/r/101261/s/149/
goto-dialog-initial-view-search
  http://git.reviewboard.kde.org/r/101261/s/150/
goto-dialog-search-results
  http://git.reviewboard.kde.org/r/101261/s/151/


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110430/89fa4506/attachment.htm