<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101261/">http://git.reviewboard.kde.org/r/101261/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a search input field to the 'Go To...' dialog used in the mobile application. It brings the same search feature the desktop application has in the Navigation tab, i.e. a search querying the search runners and displaying results in the list view. Given that it relies on existing features, the code is pretty straightforward. I'm mainly interested in feedback regarding usability of the dialog and have attached three screenshots showing the new dialog on the N900.
I'd like the user to recognize that the dialog has two modes. One where you select a place to go to from a set of predefined places (bookmarks, waypoints of the route). The other one where you search for a place. While I'd like to avoid using tabs or more than one window, I'd also like to avoid merging both modes as that would easily be understood as the search feature working as a filter on the bookmarks. Therefore I added the push button to switch between both modes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Desktop and N900.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/GoToDialog.h <span style="color: grey">(62c358f)</span></li>
<li>src/lib/GoToDialog.cpp <span style="color: grey">(caeff72)</span></li>
<li>src/lib/GoToDialog.ui <span style="color: grey">(f0756a3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101261/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101261/s/149/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/30/screenshot99_1_400x100.png" style="border: 1px black solid;" alt="goto-dialog-initial-view" /></a>
<a href="http://git.reviewboard.kde.org/r/101261/s/150/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/30/screenshot100_1_400x100.png" style="border: 1px black solid;" alt="goto-dialog-initial-view-search" /></a>
<a href="http://git.reviewboard.kde.org/r/101261/s/151/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/30/screenshot101_1_400x100.png" style="border: 1px black solid;" alt="goto-dialog-search-results" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>