[Marble-devel] Re: Review Request: Search option in the 'Go To...' dialog

Commit Hook null at kde.org
Wed May 4 19:01:42 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101261/#review3105
-----------------------------------------------------------


This review has been submitted with commit 7ae9e216af51d57128f3e8b14f3e9ab4f835cd85 by Dennis Nienhüser.

- Commit


On April 30, 2011, 10:21 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101261/
> -----------------------------------------------------------
> 
> (Updated April 30, 2011, 10:21 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> Adds a search input field to the 'Go To...' dialog used in the mobile application. It brings the same search feature the desktop application has in the Navigation tab, i.e. a search querying the search runners and displaying results in the list view. Given that it relies on existing features, the code is pretty straightforward. I'm mainly interested in feedback regarding usability of the dialog and have attached three screenshots showing the new dialog on the N900.
> 
> I'd like the user to recognize that the dialog has two modes. One where you select a place to go to from a set of predefined places (bookmarks, waypoints of the route). The other one where you search for a place. While I'd like to avoid using tabs or more than one window, I'd also like to avoid merging both modes as that would easily be understood as the search feature working as a filter on the bookmarks. Therefore I added the push button to switch between both modes.
> 
> 
> Diffs
> -----
> 
>   src/lib/GoToDialog.h 62c358f 
>   src/lib/GoToDialog.cpp caeff72 
>   src/lib/GoToDialog.ui f0756a3 
> 
> Diff: http://git.reviewboard.kde.org/r/101261/diff
> 
> 
> Testing
> -------
> 
> Desktop and N900.
> 
> 
> Screenshots
> -----------
> 
> goto-dialog-initial-view
>   http://git.reviewboard.kde.org/r/101261/s/149/
> goto-dialog-initial-view-search
>   http://git.reviewboard.kde.org/r/101261/s/150/
> goto-dialog-search-results
>   http://git.reviewboard.kde.org/r/101261/s/151/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110504/8751598e/attachment-0001.htm 


More information about the Marble-devel mailing list