[Marble-devel] Re: Review Request: Remove MarbleDataFacade; use MarbleModel instead

[Bernhard Beschow]

Am Sonntag, 27. März 2011, 13:08:28 schrieb Inge Wallin:
> On Tuesday, March 22, 2011 23:42:44 Bernhard Beschow wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://svn.reviewboard.kde.org/r/6624/
> > -----------------------------------------------------------
> > 
> > Review request for marble.
> > 
> > 
> > Summary
> > -------
> > 
> > MarbleDataFacade is basically a wrapper for MarbleModel and is used in
> > RenderPlugins. Since MarbleModel is exported, MarbleDataFacace seems
> > redundant
> 
> Here is the explanation for the facade.  It's actually the class 
> documentation.  Did you read it?
> 
> // MarbleDataFacade is an object that provides a read-only interface
> // to internal Marble data.  This is usable in e.g. plugins.
> 
> So how are you going to provide a read-only version of the Model?

A read-only version of MarbleModel is provided for plugins via "const MarbleModel*" rather than a "MarbleDataFacade*".

> Also, I am a bit concerned with the removal of backwords binary compatibility 
> by a lot of patches lately.  Is this a new policy?

We have a policy to stay binary compatible only within bugfix releases. Therefore, 0.11.x is binary compatible between two different x, and 0.x is not.

-- Bernhard