[Marble-devel] Re: Review Request: Remove MarbleDataFacade; use MarbleModel instead

[Inge Wallin]

On Monday, March 28, 2011 22:55:26 Bernhard Beschow wrote:
> Am Sonntag, 27. März 2011, 13:08:28 schrieb Inge Wallin:
> > On Tuesday, March 22, 2011 23:42:44 Bernhard Beschow wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://svn.reviewboard.kde.org/r/6624/
> > > -----------------------------------------------------------
> > > 
> > > Review request for marble.
> > > 
> > > 
> > > Summary
> > > -------
> > > 
> > > MarbleDataFacade is basically a wrapper for MarbleModel and is used in
> > > RenderPlugins. Since MarbleModel is exported, MarbleDataFacace seems
> > > redundant
> > 
> > Here is the explanation for the facade.  It's actually the class
> > documentation.  Did you read it?
> > 
> > // MarbleDataFacade is an object that provides a read-only interface
> > // to internal Marble data.  This is usable in e.g. plugins.
> > 
> > So how are you going to provide a read-only version of the Model?
> 
> A read-only version of MarbleModel is provided for plugins via "const
> MarbleModel*" rather than a "MarbleDataFacade*".

Ah, ok.  Sorry for butting in, but I thought this was a case of "didn't think 
of that".  :-)  Also, now when I read my mail back, I see that it sounds much 
harsher than it was meant.  I blame being in a hurry.

> > Also, I am a bit concerned with the removal of backwords binary
> > compatibility by a lot of patches lately.  Is this a new policy?
> 
> We have a policy to stay binary compatible only within bugfix releases.
> Therefore, 0.11.x is binary compatible between two different x, and 0.x is
> not.

Ok, I see.  I'm not sure I would agree with that policy, esp. for the library, 
but on the other hand I'm not active in Marble anymore so I don't have a say.  

	-Inge