[Marble-devel] Re: Review Request: Remove MarbleDataFacade; use MarbleModel instead
Inge Wallin
inge at lysator.liu.se
Sun Mar 27 13:08:28 CEST 2011
On Tuesday, March 22, 2011 23:42:44 Bernhard Beschow wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6624/
> -----------------------------------------------------------
>
> Review request for marble.
>
>
> Summary
> -------
>
> MarbleDataFacade is basically a wrapper for MarbleModel and is used in
> RenderPlugins. Since MarbleModel is exported, MarbleDataFacace seems
> redundant
Here is the explanation for the facade. It's actually the class
documentation. Did you read it?
// MarbleDataFacade is an object that provides a read-only interface
// to internal Marble data. This is usable in e.g. plugins.
So how are you going to provide a read-only version of the Model?
Also, I am a bit concerned with the removal of backwords binary compatibility
by a lot of patches lately. Is this a new policy?
-Inge
More information about the Marble-devel
mailing list