[Marble-devel] Review Request: gpx waypoint/route improvements

Anders Lund anders at alweb.dk
Sun Dec 18 16:16:12 UTC 2011 


> On Dec. 18, 2011, 2:18 p.m., Thibaut Gridel wrote:
> > src/plugins/runner/gpx/handlers/GpxSymbols.h, line 33
> > <http://git.reviewboard.kde.org/r/103407/diff/2/?file=43706#file43706line33>
> >
> >     As discussed, the icons for theme should not duplicate what already exists in GeoDataFeature like enum and mapping to a file name.
> >     
> >     The usecase to have a different theming than the osm purpose is valid, but it seems the geodatafeature theming which tried to merge legacy marble categories and osm ones is sidetracked.
> >     
> >     Because there will need a gpx::sym name to GeoDataFeature::GeoDataVisualCategory mapping anyway this static map can stay.
> >     
> >     However, the solution should be in defining multiple themes in geodatafeature more than doing one more mapping to filename on the side.

I'm not sure how to go on about this.

The list is very long, do you think the current visualcategory enum should be extended that much?
The possible list of waypoint icons is infinite, and should possibly be user configurable. 
The list I have is not very good, it is probably a bit outdated (it comes from gpsbabel, and have been the same all the time I used that).

I discussed with tackat on irc if it would be an idea to put the key into a config file, that would make it easy for users to adjust it to their needs, and it would be extensible. That would be a list of <gpx sym value> = <icon file name>, + the name of a theme folder - if absolute it would be a user defined location, else a marble path.

The goal is to try to get it right, so that users see a reasobably well chosen symbol when their file is loaded.

Any suggestion is wellcome, and I will try to see if I can come up with a solution.


> On Dec. 18, 2011, 2:18 p.m., Thibaut Gridel wrote:
> > src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp, line 44
> > <http://git.reviewboard.kde.org/r/103407/diff/1-2/?file=43341#file43341line44>
> >
> >     why did rtept disappear?

It got too complex, because there are so many ways a gpx file can be built. I found quite many has both waypoints and routepoints at same locations, leading to overcrowded screens. Same happens with detailed routes with many points. So I decided to only show the linestring, silently dismissing other aspects of rtept. This after testing with lots of gox files from various sources.


> On Dec. 18, 2011, 2:18 p.m., Thibaut Gridel wrote:
> > src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp, line 50
> > <http://git.reviewboard.kde.org/r/103407/diff/1-2/?file=43346#file43346line50>
> >
> >     Is this in or out :) ?

Hm, I thought i removed that... will do, thanks :)


> On Dec. 18, 2011, 2:18 p.m., Thibaut Gridel wrote:
> > src/plugins/runner/gpx/GpxRunner.cpp, line 54
> > <http://git.reviewboard.kde.org/r/103407/diff/2/?file=43689#file43689line54>
> >
> >     This shouldn't happen here, because various usecases want different solutions, hence the parameter to the method.

Ok, I will change that back.


> On Dec. 18, 2011, 2:18 p.m., Thibaut Gridel wrote:
> > src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp, line 29
> > <http://git.reviewboard.kde.org/r/103407/diff/2/?file=43693#file43693line29>
> >
> >     s/some sort of keyword/a comment/

Changed to "a keyword", it is rather a keyword than a comment. It is used for the "role" string in marble information dialog.


> On Dec. 18, 2011, 2:18 p.m., Thibaut Gridel wrote:
> > src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp, line 52
> > <http://git.reviewboard.kde.org/r/103407/diff/2/?file=43693#file43693line52>
> >
> >     Why override the name here?
> >     is there another storage solution?

The comment is the "friendly name", so most often much better than "name" in marble. In small gps devices there is often a limit to the name of 5-6 characters, so names are odd. For example geocaches use a name like "GC93X98", while the comment is the actual name of the cache. Similar with other files I have seen, the name is often a number or 5-letter code, while the cmt contains a meaningful string.

I thought it would be much nicer to have the friendly string displayed, and I still believe that after the testing I have done.

Alternative storage would be in the extended data, but that does not display it.


> On Dec. 18, 2011, 2:18 p.m., Thibaut Gridel wrote:
> > src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp, line 73
> > <http://git.reviewboard.kde.org/r/103407/diff/2/?file=43696#file43696line73>
> >
> >     Route points are not geodataplacemarks anymore, is this styling still needed?

Nope, will remove


- Anders


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103407/#review9033
-----------------------------------------------------------


On Dec. 18, 2011, 4:08 p.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103407/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 4:08 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> More gpx improvements:
> * Use desc tag to add waypoint and route descriptions
> * Set a default Role for routepoints and waypoints, and use the gpx type tag to change that if present
> * Support custom role by displaying a custom role string in placemark information dialog if present
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 63b048b 
>   data/bitmaps/markers/accommodation_camping.p.20.png PRE-CREATION 
>   data/bitmaps/markers/accommodation_caravan_park.p.20.png PRE-CREATION 
>   data/bitmaps/markers/accommodation_hotel.p.20.png PRE-CREATION 
>   data/bitmaps/markers/accommodation_hotel2.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_court.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_library.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_police.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_post_office.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_telephone.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_toilets.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_town_hall.p.20.png PRE-CREATION 
>   data/bitmaps/markers/barrier_exit.p.20.png PRE-CREATION 
>   data/bitmaps/markers/barrier_lift_gate.p.20.png PRE-CREATION 
>   data/bitmaps/markers/barrier_toll_booth.p.20.png PRE-CREATION 
>   data/bitmaps/markers/education_school.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_bar.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_drinkingtap.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_fastfood.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_pizza.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_restaurant.p.20.png PRE-CREATION 
>   data/bitmaps/markers/generic_circle_with_x.p.20.png PRE-CREATION 
>   data/bitmaps/markers/generic_flag.p.20.png PRE-CREATION 
>   data/bitmaps/markers/generic_smiley.p.20.png PRE-CREATION 
>   data/bitmaps/markers/geocaching_geocache.p.20.png PRE-CREATION 
>   data/bitmaps/markers/health_hospital.p.20.png PRE-CREATION 
>   data/bitmaps/markers/health_pharmacy.p.20.png PRE-CREATION 
>   data/bitmaps/markers/landuse_coniferous_and_deciduous.p.20.png PRE-CREATION 
>   data/bitmaps/markers/landuse_quary.p.20.png PRE-CREATION 
>   data/bitmaps/markers/money_bank2.p.20.png PRE-CREATION 
>   data/bitmaps/markers/place_of_worship_christian.p.20.png PRE-CREATION 
>   data/bitmaps/markers/place_of_worship_christian3.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_embassy.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_mine.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_mountain_pass.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_peak2.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_tower_communications.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_car.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_car_repair.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_convenience.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_department_store.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_supermarket.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_fishing.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_golf.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_gym.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_iceskating.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_leisure_centre.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_shooting.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_skiing_crosscountry.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_skiing_downhill.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_stadium.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_swimming_outdoor.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_attraction.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_beach.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_casino.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_cinema.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_information.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_museum.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_picnic.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_scenic_area.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_theatre.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_theme_park.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_view_point.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_wreck.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_zoo.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_airport.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_fuel.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_helicopter.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_marina.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_parking.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_rental_car.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_slipway.p.20.png PRE-CREATION 
>   data/bitmaps/markers/water_dam.p.20.png PRE-CREATION 
>   src/lib/PlacemarkInfoDialog.cpp e9889ee 
>   src/plugins/runner/gpx/CMakeLists.txt e0d3e07 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.h c5c35f7 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp 8355a3b 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp 14ea21f 
>   src/plugins/runner/gpx/handlers/GPXnameTagHandler.h 5ff3dca 
>   src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp 400c9c8 
>   src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp 022744d 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h c5b420a 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp 994fcbf 
>   src/plugins/runner/gpx/handlers/GPXsymTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXsymTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp b7efbe4 
>   src/plugins/runner/gpx/handlers/GpxSymbols.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GpxSymbols.cpp PRE-CREATION 
>   your-patch.patch 96675b8 
> 
> Diff: http://git.reviewboard.kde.org/r/103407/diff/diff
> 
> 
> Testing
> -------
> 
> I've been using this without problems, and verified that descriptions and roles display correctly
> Tried this loading a vareity of different gpx files found on the net
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111218/9e68af7a/attachment-0001.html>

More information about the Marble-devel mailing list