[Marble-devel] Review Request: gpx waypoint/route improvements

Thibaut Gridel tgridel at free.fr
Sun Dec 18 14:18:23 UTC 2011 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103407/#review9033
-----------------------------------------------------------


Good work, the patch solves your case to have styling for gpx.
Please check copyrights in headers.

The icon set proposed match the current file scheme used by osm as well.
We need this patch to evolve into maintainable multiple theming, so it's only a first step.


src/plugins/runner/gpx/CMakeLists.txt
<http://git.reviewboard.kde.org/r/103407/#comment7487>

    



src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp
<http://git.reviewboard.kde.org/r/103407/#comment7479>

    why did rtept disappear?



src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp
<http://git.reviewboard.kde.org/r/103407/#comment7489>

    Is this in or out :) ?



src/plugins/runner/gpx/GpxRunner.cpp
<http://git.reviewboard.kde.org/r/103407/#comment7476>

    This shouldn't happen here, because various usecases want different solutions, hence the parameter to the method.



src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp
<http://git.reviewboard.kde.org/r/103407/#comment7477>

    s/some sort of keyword/a comment/



src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp
<http://git.reviewboard.kde.org/r/103407/#comment7478>

    Why override the name here?
    is there another storage solution?



src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp
<http://git.reviewboard.kde.org/r/103407/#comment7488>

    Route points are not geodataplacemarks anymore, is this styling still needed?



src/plugins/runner/gpx/handlers/GpxSymbols.h
<http://git.reviewboard.kde.org/r/103407/#comment7490>

    As discussed, the icons for theme should not duplicate what already exists in GeoDataFeature like enum and mapping to a file name.
    
    The usecase to have a different theming than the osm purpose is valid, but it seems the geodatafeature theming which tried to merge legacy marble categories and osm ones is sidetracked.
    
    Because there will need a gpx::sym name to GeoDataFeature::GeoDataVisualCategory mapping anyway this static map can stay.
    
    However, the solution should be in defining multiple themes in geodatafeature more than doing one more mapping to filename on the side.


- Thibaut Gridel


On Dec. 18, 2011, 11:29 a.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103407/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 11:29 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> More gpx improvements:
> * Use desc tag to add waypoint and route descriptions
> * Set a default Role for routepoints and waypoints, and use the gpx type tag to change that if present
> * Support custom role by displaying a custom role string in placemark information dialog if present
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 63b048b 
>   data/bitmaps/markers/accommodation_camping.p.20.png PRE-CREATION 
>   data/bitmaps/markers/accommodation_caravan_park.p.20.png PRE-CREATION 
>   data/bitmaps/markers/accommodation_hotel.p.20.png PRE-CREATION 
>   data/bitmaps/markers/accommodation_hotel2.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_court.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_library.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_police.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_post_office.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_telephone.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_toilets.p.20.png PRE-CREATION 
>   data/bitmaps/markers/amenity_town_hall.p.20.png PRE-CREATION 
>   data/bitmaps/markers/barrier_exit.p.20.png PRE-CREATION 
>   data/bitmaps/markers/barrier_lift_gate.p.20.png PRE-CREATION 
>   data/bitmaps/markers/barrier_toll_booth.p.20.png PRE-CREATION 
>   data/bitmaps/markers/education_school.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_bar.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_drinkingtap.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_fastfood.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_pizza.p.20.png PRE-CREATION 
>   data/bitmaps/markers/food_restaurant.p.20.png PRE-CREATION 
>   data/bitmaps/markers/generic_circle_with_x.p.20.png PRE-CREATION 
>   data/bitmaps/markers/generic_flag.p.20.png PRE-CREATION 
>   data/bitmaps/markers/generic_smiley.p.20.png PRE-CREATION 
>   data/bitmaps/markers/geocaching_geocache.p.20.png PRE-CREATION 
>   data/bitmaps/markers/health_hospital.p.20.png PRE-CREATION 
>   data/bitmaps/markers/health_pharmacy.p.20.png PRE-CREATION 
>   data/bitmaps/markers/landuse_coniferous_and_deciduous.p.20.png PRE-CREATION 
>   data/bitmaps/markers/landuse_quary.p.20.png PRE-CREATION 
>   data/bitmaps/markers/money_bank2.p.20.png PRE-CREATION 
>   data/bitmaps/markers/place_of_worship_christian.p.20.png PRE-CREATION 
>   data/bitmaps/markers/place_of_worship_christian3.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_embassy.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_mine.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_mountain_pass.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_peak2.p.20.png PRE-CREATION 
>   data/bitmaps/markers/poi_tower_communications.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_car.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_car_repair.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_convenience.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_department_store.p.20.png PRE-CREATION 
>   data/bitmaps/markers/shopping_supermarket.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_fishing.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_golf.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_gym.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_iceskating.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_leisure_centre.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_shooting.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_skiing_crosscountry.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_skiing_downhill.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_stadium.p.20.png PRE-CREATION 
>   data/bitmaps/markers/sport_swimming_outdoor.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_attraction.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_beach.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_casino.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_cinema.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_information.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_museum.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_picnic.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_scenic_area.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_theatre.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_theme_park.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_view_point.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_wreck.p.20.png PRE-CREATION 
>   data/bitmaps/markers/tourist_zoo.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_airport.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_fuel.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_helicopter.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_marina.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_parking.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_rental_car.p.20.png PRE-CREATION 
>   data/bitmaps/markers/transport_slipway.p.20.png PRE-CREATION 
>   data/bitmaps/markers/water_dam.p.20.png PRE-CREATION 
>   src/lib/PlacemarkInfoDialog.cpp e9889ee 
>   src/plugins/runner/gpx/CMakeLists.txt e0d3e07 
>   src/plugins/runner/gpx/GpxRunner.cpp 6ff1390 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.h c5c35f7 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp 8355a3b 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp 14ea21f 
>   src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp 400c9c8 
>   src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp 022744d 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h c5b420a 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp 994fcbf 
>   src/plugins/runner/gpx/handlers/GPXsymTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXsymTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp b7efbe4 
>   src/plugins/runner/gpx/handlers/GpxSymbols.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GpxSymbols.cpp PRE-CREATION 
>   your-patch.patch 96675b8 
> 
> Diff: http://git.reviewboard.kde.org/r/103407/diff/diff
> 
> 
> Testing
> -------
> 
> I've been using this without problems, and verified that descriptions and roles display correctly
> Tried this loading a vareity of different gpx files found on the net
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111218/49c2174d/attachment-0001.html>

More information about the Marble-devel mailing list