<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103407/">http://git.reviewboard.kde.org/r/103407/</a>
     </td>
    </tr>
   </table>
   <br />








<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 18th, 2011, 2:18 p.m., <b>Thibaut Gridel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103407/diff/1-2/?file=43341#file43341line44" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp</a>
    <span style="font-weight: normal;">

     (Diff revisions 1 - 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GPX_DEFINE_TAG_HANDLER(name)</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="o">||</span> <span class="n">parentItem</span><span class="p">.</span><span class="n">represents</span><span class="p">(</span><span class="n">gpxTag_<span class="hl">rtept</span></span><span class="p">))</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="o">||</span> <span class="n">parentItem</span><span class="p">.</span><span class="n">represents</span><span class="p">(</span><span class="n">gpxTag_<span class="hl">trk</span></span><span class="p">))</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why did rtept disappear?</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It got too complex, because there are so many ways a gpx file can be built. I found quite many has both waypoints and routepoints at same locations, leading to overcrowded screens. Same happens with detailed routes with many points. So I decided to only show the linestring, silently dismissing other aspects of rtept. This after testing with lots of gox files from various sources.</pre>
<br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 18th, 2011, 2:18 p.m., <b>Thibaut Gridel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103407/diff/1-2/?file=43346#file43346line50" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp</a>
    <span style="font-weight: normal;">

     (Diff revisions 1 - 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="o">||</span> <span class="n">parentItem</span><span class="p">.</span><span class="n">represents</span><span class="p">(</span><span class="n">gpxTag_rtept</span><span class="p">))</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="cm"><span class="hl">/*</span>|| parentItem.represents(gpxTag_rtept)<span class="hl">*/</span></span><span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this in or out :) ?</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, I thought i removed that... will do, thanks :)</pre>
<br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 18th, 2011, 2:18 p.m., <b>Thibaut Gridel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103407/diff/2/?file=43689#file43689line54" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/gpx/GpxRunner.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GpxRunner::parseFile( const QString &fileName, DocumentRole role = UnknownDocument )</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">doc</span><span class="o">-></span><span class="n">setDocumentRole</span><span class="p">(</span> <span class="n"><span class="hl">role</span></span> <span class="p">);</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">doc</span><span class="o">-></span><span class="n">setDocumentRole</span><span class="p">(</span> <span class="n"><span class="hl">Marble</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">UserDocument</span></span> <span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This shouldn't happen here, because various usecases want different solutions, hence the parameter to the method.</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I will change that back.</pre>
<br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 18th, 2011, 2:18 p.m., <b>Thibaut Gridel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103407/diff/2/?file=43693#file43693line29" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">// type is used in wpt, rte and trk to provide some sort of keyword, like "Geocache/traditional cache",</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">s/some sort of keyword/a comment/</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed to "a keyword", it is rather a keyword than a comment. It is used for the "role" string in marble information dialog.</pre>
<br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 18th, 2011, 2:18 p.m., <b>Thibaut Gridel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103407/diff/2/?file=43693#file43693line52" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">cmt</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">&&</span> <span class="n">cmt</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span class="o">></span> <span class="n">placemark</span><span class="o">-></span><span class="n">name</span><span class="p">().</span><span class="n">length</span><span class="p">())</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why override the name here?
is there another storage solution?</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The comment is the "friendly name", so most often much better than "name" in marble. In small gps devices there is often a limit to the name of 5-6 characters, so names are odd. For example geocaches use a name like "GC93X98", while the comment is the actual name of the cache. Similar with other files I have seen, the name is often a number or 5-letter code, while the cmt contains a meaningful string.

I thought it would be much nicer to have the friendly string displayed, and I still believe that after the testing I have done.

Alternative storage would be in the extended data, but that does not display it.</pre>
<br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 18th, 2011, 2:18 p.m., <b>Thibaut Gridel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103407/diff/2/?file=43696#file43696line73" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GeoNode* GPXgpxTagHandler::parse(GeoParser& parser) const</pre></td>

  </tr>
 </tbody>






 
 

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="c1">// routepoint style</span></pre></td>
    <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="c1">// routepoint style</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Route points are not geodataplacemarks anymore, is this styling still needed?</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope, will remove</pre>
<br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 18th, 2011, 2:18 p.m., <b>Thibaut Gridel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103407/diff/2/?file=43706#file43706line33" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/gpx/handlers/GpxSymbols.h</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace gpx {</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">GpxSymbols</span> <span class="p">{</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed, the icons for theme should not duplicate what already exists in GeoDataFeature like enum and mapping to a file name.

The usecase to have a different theming than the osm purpose is valid, but it seems the geodatafeature theming which tried to merge legacy marble categories and osm ones is sidetracked.

Because there will need a gpx::sym name to GeoDataFeature::GeoDataVisualCategory mapping anyway this static map can stay.

However, the solution should be in defining multiple themes in geodatafeature more than doing one more mapping to filename on the side.</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure how to go on about this.

The list is very long, do you think the current visualcategory enum should be extended that much?
The possible list of waypoint icons is infinite, and should possibly be user configurable. 
The list I have is not very good, it is probably a bit outdated (it comes from gpsbabel, and have been the same all the time I used that).

I discussed with tackat on irc if it would be an idea to put the key into a config file, that would make it easy for users to adjust it to their needs, and it would be extensible. That would be a list of <gpx sym value> = <icon file name>, + the name of a theme folder - if absolute it would be a user defined location, else a marble path.

The goal is to try to get it right, so that users see a reasobably well chosen symbol when their file is loaded.

Any suggestion is wellcome, and I will try to see if I can come up with a solution.</pre>
<br />




<p>- Anders</p>


<br />
<p>On December 18th, 2011, 4:08 p.m., Anders Lund wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble.</div>
<div>By Anders Lund.</div>


<p style="color: grey;"><i>Updated Dec. 18, 2011, 4:08 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More gpx improvements:
* Use desc tag to add waypoint and route descriptions
* Set a default Role for routepoints and waypoints, and use the gpx type tag to change that if present
* Support custom role by displaying a custom role string in placemark information dialog if present
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've been using this without problems, and verified that descriptions and roles display correctly
Tried this loading a vareity of different gpx files found on the net</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>data/CMakeLists.txt <span style="color: grey">(63b048b)</span></li>

 <li>data/bitmaps/markers/accommodation_camping.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/accommodation_caravan_park.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/accommodation_hotel.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/accommodation_hotel2.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/amenity_court.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/amenity_library.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/amenity_police.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/amenity_post_office.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/amenity_telephone.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/amenity_toilets.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/amenity_town_hall.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/barrier_exit.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/barrier_lift_gate.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/barrier_toll_booth.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/education_school.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/food_bar.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/food_drinkingtap.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/food_fastfood.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/food_pizza.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/food_restaurant.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/generic_circle_with_x.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/generic_flag.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/generic_smiley.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/geocaching_geocache.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/health_hospital.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/health_pharmacy.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/landuse_coniferous_and_deciduous.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/landuse_quary.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/money_bank2.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/place_of_worship_christian.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/place_of_worship_christian3.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/poi_embassy.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/poi_mine.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/poi_mountain_pass.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/poi_peak2.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/poi_tower_communications.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/shopping_car.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/shopping_car_repair.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/shopping_convenience.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/shopping_department_store.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/shopping_supermarket.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_fishing.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_golf.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_gym.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_iceskating.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_leisure_centre.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_shooting.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_skiing_crosscountry.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_skiing_downhill.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_stadium.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/sport_swimming_outdoor.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_attraction.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_beach.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_casino.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_cinema.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_information.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_museum.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_picnic.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_scenic_area.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_theatre.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_theme_park.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_view_point.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_wreck.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/tourist_zoo.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/transport_airport.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/transport_fuel.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/transport_helicopter.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/transport_marina.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/transport_parking.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/transport_rental_car.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/transport_slipway.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/bitmaps/markers/water_dam.p.20.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/PlacemarkInfoDialog.cpp <span style="color: grey">(e9889ee)</span></li>

 <li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(e0d3e07)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXElementDictionary.h <span style="color: grey">(c5c35f7)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp <span style="color: grey">(8355a3b)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXdescTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp <span style="color: grey">(14ea21f)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXnameTagHandler.h <span style="color: grey">(5ff3dca)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp <span style="color: grey">(400c9c8)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp <span style="color: grey">(022744d)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h <span style="color: grey">(c5b420a)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp <span style="color: grey">(994fcbf)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXsymTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXsymTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp <span style="color: grey">(b7efbe4)</span></li>

 <li>src/plugins/runner/gpx/handlers/GpxSymbols.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/runner/gpx/handlers/GpxSymbols.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>your-patch.patch <span style="color: grey">(96675b8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103407/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>