[Marble-devel] Review Request: render() and paint(): free from GeoSceneLayer slavery

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102355/#review5778
-----------------------------------------------------------


While I definetly like this patch, I'm a bit concerned about BC, which will force all our third parties to update their code. Ideally, I'd like to see some deprecation phase.

- Bernhard


On Aug. 17, 2011, 5:56 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102355/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 5:56 p.m.)
> 
> 
> Review request for Marble, Bernhard Beschow and Bastian Holst.
> 
> 
> Summary
> -------
> 
> Please give me a reason not to apply this one...
> No code would do more than Q_UNUSED( layer ) or propagate.
> Will wait a bit, as it impacts so much code.
> 
> As a side note, GeoSceneLayer.h is not installed so the class needs to be defined in users code or the header be installed.
> 
> 
> Diffs
> -----
> 
>   src/lib/AbstractDataPlugin.h 0638734 
>   src/lib/AbstractDataPlugin.cpp 375d7e3 
>   src/lib/AbstractFloatItem.h ea6050e 
>   src/lib/AbstractFloatItem.cpp 9de45b5 
>   src/lib/AtmosphereLayer.h d825b2a 
>   src/lib/AtmosphereLayer.cpp dcf2d33 
>   src/lib/FogLayer.h e86f79d 
>   src/lib/FogLayer.cpp 24a1325 
>   src/lib/FpsLayer.h eb3743f 
>   src/lib/FpsLayer.cpp 9c07485 
>   src/lib/GeometryLayer.h 7867281 
>   src/lib/GeometryLayer.cpp 4ca27f0 
>   src/lib/LayerInterface.h 1241ccc 
>   src/lib/MeasureTool.h 38bbac3 
>   src/lib/MeasureTool.cpp 56691f0 
>   src/lib/PlacemarkLayout.h 34383fe 
>   src/lib/PlacemarkLayout.cpp af17b68 
>   src/lib/VectorMapBaseLayer.h 7db584e 
>   src/lib/VectorMapBaseLayer.cpp ab4f360 
>   src/lib/VectorMapLayer.h 91a3f35 
>   src/lib/VectorMapLayer.cpp f05c88a 
>   src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.h 30fcc46 
>   src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp fd74b3a 
>   src/lib/geodata/graphicsitem/GeoPointGraphicsItem.h fa3cdf7 
>   src/lib/geodata/graphicsitem/GeoPointGraphicsItem.cpp 9e8c6f5 
>   src/lib/graphicsview/FrameGraphicsItem.h f29feba 
>   src/lib/graphicsview/FrameGraphicsItem.cpp e27cddb 
>   src/lib/graphicsview/LabelGraphicsItem.h 8599663 
>   src/lib/graphicsview/LabelGraphicsItem.cpp a47d542 
>   src/lib/graphicsview/MarbleGraphicsItem.h cf92570 
>   src/lib/graphicsview/MarbleGraphicsItem.cpp 1bfbd1b 
>   src/lib/graphicsview/WidgetGraphicsItem.h d98b632 
>   src/lib/graphicsview/WidgetGraphicsItem.cpp 7a493bf 
>   src/lib/graphicsview/screengraphicsitem/PointScreenGraphicsItem.h 61dbea7 
>   src/lib/graphicsview/screengraphicsitem/PointScreenGraphicsItem.cpp f976400 
>   src/lib/routing/RoutingLayer.h 8610f18 
>   src/lib/routing/RoutingLayer.cpp 6eec57a 
>   src/plugins/render/aprs/AprsObject.h d6bb7e0 
>   src/plugins/render/aprs/AprsObject.cpp 1318f83 
>   src/plugins/render/aprs/AprsPlugin.h 7bc4586 
>   src/plugins/render/aprs/AprsPlugin.cpp 5acb003 
>   src/plugins/render/compass/CompassFloatItem.h 69b613e 
>   src/plugins/render/compass/CompassFloatItem.cpp 371445a 
>   src/plugins/render/crosshairs/CrosshairsPlugin.h a9d2dad 
>   src/plugins/render/crosshairs/CrosshairsPlugin.cpp 84bce38 
>   src/plugins/render/earthquake/EarthquakeItem.h 387c13d 
>   src/plugins/render/earthquake/EarthquakeItem.cpp 846052a 
>   src/plugins/render/graticule/GraticulePlugin.h ee37cec 
>   src/plugins/render/graticule/GraticulePlugin.cpp 6fb35c9 
>   src/plugins/render/mapscale/MapScaleFloatItem.h f25bef9 
>   src/plugins/render/mapscale/MapScaleFloatItem.cpp 8014ce7 
>   src/plugins/render/opendesktop/OpenDesktopItem.h 78078d9 
>   src/plugins/render/opendesktop/OpenDesktopItem.cpp b7930ee 
>   src/plugins/render/overviewmap/OverviewMap.h 3c60292 
>   src/plugins/render/overviewmap/OverviewMap.cpp c0e02db 
>   src/plugins/render/positionmarker/PositionMarker.h c572ec2 
>   src/plugins/render/positionmarker/PositionMarker.cpp 6133921 
>   src/plugins/render/progress/ProgressFloatItem.h 4b3ac11 
>   src/plugins/render/progress/ProgressFloatItem.cpp b1c3b00 
>   src/plugins/render/stars/StarsPlugin.h 08eb91c 
>   src/plugins/render/stars/StarsPlugin.cpp 3a48e1a 
>   src/plugins/render/sun/SunPlugin.h 632ce6d 
>   src/plugins/render/sun/SunPlugin.cpp 337d554 
>   src/plugins/render/wikipedia/WikipediaItem.h e1726aa 
>   src/plugins/render/wikipedia/WikipediaItem.cpp 4e9c1b1 
> 
> Diff: http://git.reviewboard.kde.org/r/102355/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110817/b71375f2/attachment.html>