<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102355/">http://git.reviewboard.kde.org/r/102355/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While I definetly like this patch, I'm a bit concerned about BC, which will force all our third parties to update their code. Ideally, I'd like to see some deprecation phase.</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On August 17th, 2011, 5:56 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow and Bastian Holst.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2011, 5:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please give me a reason not to apply this one...
No code would do more than Q_UNUSED( layer ) or propagate.
Will wait a bit, as it impacts so much code.
As a side note, GeoSceneLayer.h is not installed so the class needs to be defined in users code or the header be installed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/AbstractDataPlugin.h <span style="color: grey">(0638734)</span></li>
<li>src/lib/AbstractDataPlugin.cpp <span style="color: grey">(375d7e3)</span></li>
<li>src/lib/AbstractFloatItem.h <span style="color: grey">(ea6050e)</span></li>
<li>src/lib/AbstractFloatItem.cpp <span style="color: grey">(9de45b5)</span></li>
<li>src/lib/AtmosphereLayer.h <span style="color: grey">(d825b2a)</span></li>
<li>src/lib/AtmosphereLayer.cpp <span style="color: grey">(dcf2d33)</span></li>
<li>src/lib/FogLayer.h <span style="color: grey">(e86f79d)</span></li>
<li>src/lib/FogLayer.cpp <span style="color: grey">(24a1325)</span></li>
<li>src/lib/FpsLayer.h <span style="color: grey">(eb3743f)</span></li>
<li>src/lib/FpsLayer.cpp <span style="color: grey">(9c07485)</span></li>
<li>src/lib/GeometryLayer.h <span style="color: grey">(7867281)</span></li>
<li>src/lib/GeometryLayer.cpp <span style="color: grey">(4ca27f0)</span></li>
<li>src/lib/LayerInterface.h <span style="color: grey">(1241ccc)</span></li>
<li>src/lib/MeasureTool.h <span style="color: grey">(38bbac3)</span></li>
<li>src/lib/MeasureTool.cpp <span style="color: grey">(56691f0)</span></li>
<li>src/lib/PlacemarkLayout.h <span style="color: grey">(34383fe)</span></li>
<li>src/lib/PlacemarkLayout.cpp <span style="color: grey">(af17b68)</span></li>
<li>src/lib/VectorMapBaseLayer.h <span style="color: grey">(7db584e)</span></li>
<li>src/lib/VectorMapBaseLayer.cpp <span style="color: grey">(ab4f360)</span></li>
<li>src/lib/VectorMapLayer.h <span style="color: grey">(91a3f35)</span></li>
<li>src/lib/VectorMapLayer.cpp <span style="color: grey">(f05c88a)</span></li>
<li>src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.h <span style="color: grey">(30fcc46)</span></li>
<li>src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp <span style="color: grey">(fd74b3a)</span></li>
<li>src/lib/geodata/graphicsitem/GeoPointGraphicsItem.h <span style="color: grey">(fa3cdf7)</span></li>
<li>src/lib/geodata/graphicsitem/GeoPointGraphicsItem.cpp <span style="color: grey">(9e8c6f5)</span></li>
<li>src/lib/graphicsview/FrameGraphicsItem.h <span style="color: grey">(f29feba)</span></li>
<li>src/lib/graphicsview/FrameGraphicsItem.cpp <span style="color: grey">(e27cddb)</span></li>
<li>src/lib/graphicsview/LabelGraphicsItem.h <span style="color: grey">(8599663)</span></li>
<li>src/lib/graphicsview/LabelGraphicsItem.cpp <span style="color: grey">(a47d542)</span></li>
<li>src/lib/graphicsview/MarbleGraphicsItem.h <span style="color: grey">(cf92570)</span></li>
<li>src/lib/graphicsview/MarbleGraphicsItem.cpp <span style="color: grey">(1bfbd1b)</span></li>
<li>src/lib/graphicsview/WidgetGraphicsItem.h <span style="color: grey">(d98b632)</span></li>
<li>src/lib/graphicsview/WidgetGraphicsItem.cpp <span style="color: grey">(7a493bf)</span></li>
<li>src/lib/graphicsview/screengraphicsitem/PointScreenGraphicsItem.h <span style="color: grey">(61dbea7)</span></li>
<li>src/lib/graphicsview/screengraphicsitem/PointScreenGraphicsItem.cpp <span style="color: grey">(f976400)</span></li>
<li>src/lib/routing/RoutingLayer.h <span style="color: grey">(8610f18)</span></li>
<li>src/lib/routing/RoutingLayer.cpp <span style="color: grey">(6eec57a)</span></li>
<li>src/plugins/render/aprs/AprsObject.h <span style="color: grey">(d6bb7e0)</span></li>
<li>src/plugins/render/aprs/AprsObject.cpp <span style="color: grey">(1318f83)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.h <span style="color: grey">(7bc4586)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(5acb003)</span></li>
<li>src/plugins/render/compass/CompassFloatItem.h <span style="color: grey">(69b613e)</span></li>
<li>src/plugins/render/compass/CompassFloatItem.cpp <span style="color: grey">(371445a)</span></li>
<li>src/plugins/render/crosshairs/CrosshairsPlugin.h <span style="color: grey">(a9d2dad)</span></li>
<li>src/plugins/render/crosshairs/CrosshairsPlugin.cpp <span style="color: grey">(84bce38)</span></li>
<li>src/plugins/render/earthquake/EarthquakeItem.h <span style="color: grey">(387c13d)</span></li>
<li>src/plugins/render/earthquake/EarthquakeItem.cpp <span style="color: grey">(846052a)</span></li>
<li>src/plugins/render/graticule/GraticulePlugin.h <span style="color: grey">(ee37cec)</span></li>
<li>src/plugins/render/graticule/GraticulePlugin.cpp <span style="color: grey">(6fb35c9)</span></li>
<li>src/plugins/render/mapscale/MapScaleFloatItem.h <span style="color: grey">(f25bef9)</span></li>
<li>src/plugins/render/mapscale/MapScaleFloatItem.cpp <span style="color: grey">(8014ce7)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopItem.h <span style="color: grey">(78078d9)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopItem.cpp <span style="color: grey">(b7930ee)</span></li>
<li>src/plugins/render/overviewmap/OverviewMap.h <span style="color: grey">(3c60292)</span></li>
<li>src/plugins/render/overviewmap/OverviewMap.cpp <span style="color: grey">(c0e02db)</span></li>
<li>src/plugins/render/positionmarker/PositionMarker.h <span style="color: grey">(c572ec2)</span></li>
<li>src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(6133921)</span></li>
<li>src/plugins/render/progress/ProgressFloatItem.h <span style="color: grey">(4b3ac11)</span></li>
<li>src/plugins/render/progress/ProgressFloatItem.cpp <span style="color: grey">(b1c3b00)</span></li>
<li>src/plugins/render/stars/StarsPlugin.h <span style="color: grey">(08eb91c)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(3a48e1a)</span></li>
<li>src/plugins/render/sun/SunPlugin.h <span style="color: grey">(632ce6d)</span></li>
<li>src/plugins/render/sun/SunPlugin.cpp <span style="color: grey">(337d554)</span></li>
<li>src/plugins/render/wikipedia/WikipediaItem.h <span style="color: grey">(e1726aa)</span></li>
<li>src/plugins/render/wikipedia/WikipediaItem.cpp <span style="color: grey">(4e9c1b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102355/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>