[Marble-devel] Review Request: call update() instead of repaint()

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102314/#review5675
-----------------------------------------------------------

Ship it!


Looks fine to me. Actually I had this fix on my mental TODO: It also fixes the very slow performance on MeeGo 1.2 on a WeTab/Exo PC (since that one seems to fire off really huge amounts of input events for whatever reason and the repaint only trails behind ...). 
But since I don't have much time to code these days it's great that you did the fix! Thanks a lot! :-)  
The original reason why we used repaint() was that at one point repaint was faster and more responsive than the usage of update some ~3-4 years ago (at least with zooming in using the slider) and we had done our own filtering in Marble for that reason. These days this doesn't seem to be the case anymore. So let's use update()!

- Torsten


On Aug. 13, 2011, 3:45 p.m., Kishore Jonnalagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102314/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2011, 3:45 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> use repaint() instead of update() at various places. As per the Qt documentation, it is preferable to call update() instead of repaint(). Calling update() allows qt to optimize by calling paintEvent() only once as needed after several calls to update().
> 
> 
> Diffs
> -----
> 
>   src/ControlView.cpp dec4bcf 
>   src/lib/CurrentLocationWidget.cpp 5d77b74 
>   src/lib/MarbleWidget.cpp 9ae862e 
>   src/lib/graphicsview/ScreenGraphicsItem.cpp fde960a 
>   src/lib/routing/RoutingLayer.cpp 6eec57a 
>   src/plugins/render/fileview/FileViewFloatItem.cpp 377e404 
>   src/plugins/render/osmannotate/OsmAnnotatePlugin.cpp ccc3cf4 
>   src/plugins/render/routing/RoutingPlugin.cpp bb651e5 
> 
> Diff: http://git.reviewboard.kde.org/r/102314/diff
> 
> 
> Testing
> -------
> 
> I use marblewidget in my application and it works fine (better) after the change. I have also tried the marble application.
> 
> marble was built with QTONLY.
> 
> 
> Thanks,
> 
> Kishore
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110814/4ea860ce/attachment.html>