[Marble-devel] Review Request: call update() instead of repaint()

[Kishore Jonnalagadda]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102314/
-----------------------------------------------------------

Review request for Marble.


Summary
-------

use repaint() instead of update() at various places. As per the Qt documentation, it is preferable to call update() instead of repaint(). Calling update() allows qt to optimize by calling paintEvent() only once as needed after several calls to update().


Diffs
-----

  src/ControlView.cpp dec4bcf 
  src/lib/CurrentLocationWidget.cpp 5d77b74 
  src/lib/MarbleWidget.cpp 9ae862e 
  src/lib/graphicsview/ScreenGraphicsItem.cpp fde960a 
  src/lib/routing/RoutingLayer.cpp 6eec57a 
  src/plugins/render/fileview/FileViewFloatItem.cpp 377e404 
  src/plugins/render/osmannotate/OsmAnnotatePlugin.cpp ccc3cf4 
  src/plugins/render/routing/RoutingPlugin.cpp bb651e5 

Diff: http://git.reviewboard.kde.org/r/102314/diff


Testing
-------

I use marblewidget in my application and it works fine (better) after the change. I have also tried the marble application.

marble was built with QTONLY.


Thanks,

Kishore

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110813/7c9eeaa9/attachment.html>