<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102314/">http://git.reviewboard.kde.org/r/102314/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me. Actually I had this fix on my mental TODO: It also fixes the very slow performance on MeeGo 1.2 on a WeTab/Exo PC (since that one seems to fire off really huge amounts of input events for whatever reason and the repaint only trails behind ...).
But since I don't have much time to code these days it's great that you did the fix! Thanks a lot! :-)
The original reason why we used repaint() was that at one point repaint was faster and more responsive than the usage of update some ~3-4 years ago (at least with zooming in using the slider) and we had done our own filtering in Marble for that reason. These days this doesn't seem to be the case anymore. So let's use update()!</pre>
<br />
<p>- Torsten</p>
<br />
<p>On August 13th, 2011, 3:45 p.m., Kishore Jonnalagadda wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Kishore Jonnalagadda.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2011, 3:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use repaint() instead of update() at various places. As per the Qt documentation, it is preferable to call update() instead of repaint(). Calling update() allows qt to optimize by calling paintEvent() only once as needed after several calls to update().</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I use marblewidget in my application and it works fine (better) after the change. I have also tried the marble application.
marble was built with QTONLY.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ControlView.cpp <span style="color: grey">(dec4bcf)</span></li>
<li>src/lib/CurrentLocationWidget.cpp <span style="color: grey">(5d77b74)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(9ae862e)</span></li>
<li>src/lib/graphicsview/ScreenGraphicsItem.cpp <span style="color: grey">(fde960a)</span></li>
<li>src/lib/routing/RoutingLayer.cpp <span style="color: grey">(6eec57a)</span></li>
<li>src/plugins/render/fileview/FileViewFloatItem.cpp <span style="color: grey">(377e404)</span></li>
<li>src/plugins/render/osmannotate/OsmAnnotatePlugin.cpp <span style="color: grey">(ccc3cf4)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(bb651e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102314/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>