[Marble-devel] Review Request: Have Citylights blending painted as part of the blending framework

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102171/
-----------------------------------------------------------

Review request for Marble.


Summary
-------

The Citylights blending is currently hardcoded in the MergedLayerDecorator. Besides being redundant to the blending framework, the Citylights blending can't be applied to every map theme. For instance, it is not possible to apply the Citylights blending to the Atlas theme (although it is texture-based and has the correct ServerLayout), because the Atlas theme involves post-processing. It makes therefore sense to transfer the responsibility for having a Citylights blending to the map themes.


Diffs
-----

  data/maps/earth/bluemarble/bluemarble.dgml f94d5e0 
  src/lib/MarbleMap.cpp 920a888 
  src/lib/MergedLayerDecorator.h a11e8f2 
  src/lib/MergedLayerDecorator.cpp b582a30 

Diff: http://git.reviewboard.kde.org/r/102171/diff


Testing
-------

Ported the theme "Satellite View", which seems to work great. Which other themes do we want to port?


Thanks,

Bernhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110801/cedce5a8/attachment.html>