<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102171/">http://git.reviewboard.kde.org/r/102171/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Citylights blending is currently hardcoded in the MergedLayerDecorator. Besides being redundant to the blending framework, the Citylights blending can't be applied to every map theme. For instance, it is not possible to apply the Citylights blending to the Atlas theme (although it is texture-based and has the correct ServerLayout), because the Atlas theme involves post-processing. It makes therefore sense to transfer the responsibility for having a Citylights blending to the map themes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ported the theme "Satellite View", which seems to work great. Which other themes do we want to port?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/maps/earth/bluemarble/bluemarble.dgml <span style="color: grey">(f94d5e0)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(920a888)</span></li>
<li>src/lib/MergedLayerDecorator.h <span style="color: grey">(a11e8f2)</span></li>
<li>src/lib/MergedLayerDecorator.cpp <span style="color: grey">(b582a30)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102171/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>