[Marble-devel] Review Request: Have Citylights blending painted as part of the blending framework

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102171/#review5705
-----------------------------------------------------------


This review has been submitted with commit f9793999f82f8d1a2f244b96fe9e548bdb2e662f by Bernhard Beschow to branch master.

- Commit


On Aug. 1, 2011, 5:48 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102171/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 5:48 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> The Citylights blending is currently hardcoded in the MergedLayerDecorator. Besides being redundant to the blending framework, the Citylights blending can't be applied to every map theme. For instance, it is not possible to apply the Citylights blending to the Atlas theme (although it is texture-based and has the correct ServerLayout), because the Atlas theme involves post-processing. It makes therefore sense to transfer the responsibility for having a Citylights blending to the map themes.
> 
> 
> Diffs
> -----
> 
>   data/maps/earth/bluemarble/bluemarble.dgml f94d5e0 
>   src/lib/MarbleMap.cpp 920a888 
>   src/lib/MergedLayerDecorator.h a11e8f2 
>   src/lib/MergedLayerDecorator.cpp b582a30 
> 
> Diff: http://git.reviewboard.kde.org/r/102171/diff
> 
> 
> Testing
> -------
> 
> Ported the theme "Satellite View", which seems to work great. Which other themes do we want to port?
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110815/71603810/attachment.html>