[Marble-devel] Review Request: MarbleRunner new Capability: Parsing files

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101991/#review5303
-----------------------------------------------------------



src/lib/MarbleRunnerManager.cpp
<http://git.reviewboard.kde.org/r/101991/#comment4798>

    Why is this needed? The RunnerTasks are owned by the QThreadPool, so why do they need to be saved here again?



src/lib/MarbleRunnerManager.cpp
<http://git.reviewboard.kde.org/r/101991/#comment4800>

    This slot can be removed if m_parsingTasks is not needed.



src/lib/MarbleRunnerManager.cpp
<http://git.reviewboard.kde.org/r/101991/#comment4802>

    Unread variable.


- Bernhard


On July 17, 2011, 11:18 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101991/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 11:18 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> This patch provides a new capability in the MarbleRunners, in order to parse files with various parsers in parallel.
> It will be followed by plugins matching the current files recognised in FileLoader and GeoData parser.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleAbstractRunner.h fe01370 
>   src/lib/MarbleAbstractRunner.cpp 06855f4 
>   src/lib/MarbleRunnerManager.h db4c0f3 
>   src/lib/MarbleRunnerManager.cpp cf59db5 
>   src/lib/RunnerPlugin.h 8754933 
>   src/lib/RunnerTask.h d69844c 
>   src/lib/RunnerTask.cpp 19047ed 
> 
> Diff: http://git.reviewboard.kde.org/r/101991/diff
> 
> 
> Testing
> -------
> 
> Further patches integrate this framework and successfully replace existing implementation.
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110801/c9afe9ee/attachment.html>