[Marble-devel] Review Request: MarbleRunner new Capability: Parsing files

[Thibaut Gridel]

> On Aug. 1, 2011, 5:20 p.m., Bernhard Beschow wrote:
> >

All those are copied from other retrieve*.
I was hesitant wether to :
a) stop at first returned document, clear all other parsers and be done,
b) send one signal per succesful parsing with multiple plugins,
c) or wait till everyone finished and pick best (to be determined) result.

For now I expect plugin not to provide a valid document if they are not able to parse, and also expect only one to provide results.
The implementation therefore is b) being a bit loose on checking multiple valid results.
The expectations may change if we have for example multiple backends to parse a file. (a plugin for gpsbabel comes in mind). In such a case, we may want to go for a) through fastest (and kill other plugins, reason to keep the QList)
or c) waiting and picking best result.

On the rationale of not prospective coding, i will remove the qlist and clearing slot for now.

What do you think?


- Thibaut


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101991/#review5303
-----------------------------------------------------------


On July 17, 2011, 11:18 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101991/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 11:18 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> This patch provides a new capability in the MarbleRunners, in order to parse files with various parsers in parallel.
> It will be followed by plugins matching the current files recognised in FileLoader and GeoData parser.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleAbstractRunner.h fe01370 
>   src/lib/MarbleAbstractRunner.cpp 06855f4 
>   src/lib/MarbleRunnerManager.h db4c0f3 
>   src/lib/MarbleRunnerManager.cpp cf59db5 
>   src/lib/RunnerPlugin.h 8754933 
>   src/lib/RunnerTask.h d69844c 
>   src/lib/RunnerTask.cpp 19047ed 
> 
> Diff: http://git.reviewboard.kde.org/r/101991/diff
> 
> 
> Testing
> -------
> 
> Further patches integrate this framework and successfully replace existing implementation.
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110816/6544fe46/attachment.html>