[Marble-devel] Review Request: Faster kml coordinate parsing

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101227/
-----------------------------------------------------------

Review request for Marble.


Summary
-------

Currently the KML coordinate tag handler uses a regular expression to split the incoming string, which is rather slow. This patch uses QChar::isSpace() instead to avoid the regexp slowdown. According to callgrind, long routes (~ 400 km) are parsed in half the time when using this approach.


Diffs
-----

  src/lib/geodata/handlers/kml/KmlCoordinatesTagHandler.cpp ad1fed2 

Diff: http://git.reviewboard.kde.org/r/101227/diff


Testing
-------


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110424/176906fe/attachment.htm