[Marble-devel] Re: Review Request: Faster kml coordinate parsing

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101227/#review2963
-----------------------------------------------------------

Ship it!


Looks ok to me.

- Torsten


On April 24, 2011, 9:21 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101227/
> -----------------------------------------------------------
> 
> (Updated April 24, 2011, 9:21 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> Currently the KML coordinate tag handler uses a regular expression to split the incoming string, which is rather slow. This patch uses QChar::isSpace() instead to avoid the regexp slowdown. According to callgrind, long routes (~ 400 km) are parsed in half the time when using this approach.
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/handlers/kml/KmlCoordinatesTagHandler.cpp ad1fed2 
> 
> Diff: http://git.reviewboard.kde.org/r/101227/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110429/d105af94/attachment.htm