[Marble-devel] Review Request: Fix Julian Day number handling

Sun Sep 19 16:03:41 CEST 2010

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5374/#review7677
-----------------------------------------------------------

Ship it!

Looks good to me. Thanks!

- jmho

On 2010-09-17 13:55:49, John Layt wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5374/
> -----------------------------------------------------------
> =

> (Updated 2010-09-17 13:55:49)
> =

> =

> Review request for marble.
> =

> =

> Summary
> -------
> =

> Was looking for something else when I stumbled across this and couldn't h=
elp but fix it :-)
> =

> Remove Julian Day calculation from MarbleClock as QDate already provides =
a method for this (in fact it is how QDate internally stores dates, so it's=
 way more efficient and 100% accurate).
> =

> Also, I'm no expert, but the timezone implementation doesn't look good to=
 me.  It's just a shame you can't use KDateTime/KTimeZone/KTimeZoneWidget w=
hich would do it all for you correctly.  I'll try find time to find a bette=
r way.
> =

> =

> Diffs
> -----
> =

>   /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.h 1176287 =

>   /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.cpp 1176287 =

>   /trunk/KDE/kdeedu/marble/src/lib/SunLocator.cpp 1176287 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5374/diff
> =

> =

> Testing
> -------
> =

> Ran Marble and tested Sun functions, appears to work OK to me.
> =

> =

> Thanks,
> =

> John
> =

>

--===============3954996505300995215==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://svn.reviewboard.kde.org/r/5374/">http://svn.reviewb=
oard.kde.org/r/5374/</a>
     </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good=
 to me. Thanks!</pre>
 <br />

<p>- jmho</p>

<br />
<p>On September 17th, 2010, 1:55 p.m., John Layt wrote:</p>

<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://svn.reviewboard.kde.orgrb/images/=
review_request_box_top_bg.png'); background-position: left top; background-=
repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for marble.</div>
<div>By John Layt.</div>

<p style=3D"color: grey;"><i>Updated 2010-09-17 13:55:49</i></p>

<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Was looking for something else when I stumbled across this a=
nd couldn&#39;t help but fix it :-)

Remove Julian Day calculation from MarbleClock as QDate already provides a =
method for this (in fact it is how QDate internally stores dates, so it&#39=
;s way more efficient and 100% accurate).

Also, I&#39;m no expert, but the timezone implementation doesn&#39;t look g=
ood to me.  It&#39;s just a shame you can&#39;t use KDateTime/KTimeZone/KTi=
meZoneWidget which would do it all for you correctly.  I&#39;ll try find ti=
me to find a better way.</pre>
  </td>
 </tr>
</table>

<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Ran Marble and tested Sun functions, appears to work OK to m=
e.</pre>
  </td>
 </tr>
</table>

<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleClock.h <span style=3D"color: g=
rey">(1176287)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/MarbleClock.cpp <span style=3D"color:=
 grey">(1176287)</span></li>

 <li>/trunk/KDE/kdeedu/marble/src/lib/SunLocator.cpp <span style=3D"color: =
grey">(1176287)</span></li>

</ul>

<p><a href=3D"http://svn.reviewboard.kde.org/r/5374/diff/" style=3D"margin-=
left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3954996505300995215==--

-------------------------------------------------------------