[Marble-devel] Review Request: Fix Julian Day number handling

[jensmh at gmx.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5374/#review7677
-----------------------------------------------------------

Ship it!


Looks good to me. Thanks!

- jmho


On 2010-09-17 13:55:49, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5374/
> -----------------------------------------------------------
> 
> (Updated 2010-09-17 13:55:49)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Was looking for something else when I stumbled across this and couldn't help but fix it :-)
> 
> Remove Julian Day calculation from MarbleClock as QDate already provides a method for this (in fact it is how QDate internally stores dates, so it's way more efficient and 100% accurate).
> 
> Also, I'm no expert, but the timezone implementation doesn't look good to me.  It's just a shame you can't use KDateTime/KTimeZone/KTimeZoneWidget which would do it all for you correctly.  I'll try find time to find a better way.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.h 1176287 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleClock.cpp 1176287 
>   /trunk/KDE/kdeedu/marble/src/lib/SunLocator.cpp 1176287 
> 
> Diff: http://svn.reviewboard.kde.org/r/5374/diff
> 
> 
> Testing
> -------
> 
> Ran Marble and tested Sun functions, appears to work OK to me.
> 
> 
> Thanks,
> 
> John
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100918/d65a5a39/attachment.htm