[Marble-devel] Re: Review Request: Separate version strings for Marble Virtual Globe and Marble Library

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5840/#review8717
-----------------------------------------------------------

Ship it!


Couldn't look any better :-)

- Torsten


On 2010-11-13 12:38:36, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5840/
> -----------------------------------------------------------
> 
> Review request for marble and Torsten Rahn.
> 
> 
> Summary
> -------
> 
> Splits up the version string for the library and the applications (KDE and Qt). The patch can be applied to branches/4.6 once it exists. The version number for the applications is 0.80 (1.0 Beta 1), along the lines of KDE versions (4.6 Beta 1 will be 4.5.80). Another option would be 0.9.80.
> 
> * The KDE version about dialog reports 'Marble Virtual Globe' and the application version.
> * The Qt version about dialog reports 'Marble Virtual Globe' and the application version.
> * Embedded in another application, the about dialog reports 'Marble Virtual Globe' without an application version. This can be overwritten using MarbleAboutDialog::setApplicationTitle()
> * MarbleAboutDialog (Qt version and when using MarbleWidget embedded) also reports the Marble library version.
> 
> Note that the screenshots still have some 'Marble Desktop Globe' strings that would change to 'Marble Virtual Globe' when applying the other patch.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/ControlView.h 1196401 
>   /trunk/KDE/kdeedu/marble/src/ControlView.cpp 1196401 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1196401 
>   /trunk/KDE/kdeedu/marble/src/kdemain.cpp 1196401 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleAboutDialog.h 1196401 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleAboutDialog.cpp 1196401 
>   /trunk/KDE/kdeedu/marble/src/marble_part.cpp 1196401 
> 
> Diff: http://svn.reviewboard.kde.org/r/5840/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> About dialog (KDE version)
>   http://svn.reviewboard.kde.org/r/5840/s/556/
> About dialog (Qt version)
>   http://svn.reviewboard.kde.org/r/5840/s/557/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20101114/96f61fce/attachment.htm