<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5840/">http://svn.reviewboard.kde.org/r/5840/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Couldn't look any better :-)</pre>
<br />
<p>- Torsten</p>
<br />
<p>On November 13th, 2010, 12:38 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble and Torsten Rahn.</div>
<div>By Dennis Nienhüser.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Splits up the version string for the library and the applications (KDE and Qt). The patch can be applied to branches/4.6 once it exists. The version number for the applications is 0.80 (1.0 Beta 1), along the lines of KDE versions (4.6 Beta 1 will be 4.5.80). Another option would be 0.9.80.
* The KDE version about dialog reports 'Marble Virtual Globe' and the application version.
* The Qt version about dialog reports 'Marble Virtual Globe' and the application version.
* Embedded in another application, the about dialog reports 'Marble Virtual Globe' without an application version. This can be overwritten using MarbleAboutDialog::setApplicationTitle()
* MarbleAboutDialog (Qt version and when using MarbleWidget embedded) also reports the Marble library version.
Note that the screenshots still have some 'Marble Desktop Globe' strings that would change to 'Marble Virtual Globe' when applying the other patch.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/ControlView.h <span style="color: grey">(1196401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/ControlView.cpp <span style="color: grey">(1196401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1196401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/kdemain.cpp <span style="color: grey">(1196401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleAboutDialog.h <span style="color: grey">(1196401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleAboutDialog.cpp <span style="color: grey">(1196401)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble_part.cpp <span style="color: grey">(1196401)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5840/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5840/s/556/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/13/marble-about-marble-kde_400x100.png" style="border: 1px black solid;" alt="About dialog (KDE version)" /></a>
<a href="http://svn.reviewboard.kde.org/r/5840/s/557/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/13/marble-about-marble-qt_400x100.png" style="border: 1px black solid;" alt="About dialog (Qt version)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>