[Marble-devel] Review Request: FileLoader: provide a PNT file loader so that GeoPainter could render those

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4673/#review6633
-----------------------------------------------------------

Ship it!


The patch looks nice :-)

GeoPainter is not yet able to fully replace the vectormap/vectorcomposer code. Reason is that part of the GeoDataLinearRing rendering isn't implemented yet (leads to drawing errors for Antarctica).

But as a "teaser" and for testing it's quite nice :-)

- Torsten


On 2010-07-17 12:16:10, Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4673/
> -----------------------------------------------------------
> 
> (Updated 2010-07-17 12:16:10)
> 
> 
> Review request for marble and Torsten Rahn.
> 
> 
> Summary
> -------
> 
> Title says much.
> 
> This does not deprecate or change in any way the current PNT file loading
> from DGML files, still using VectorComposer.
> 
> In fact, this can be considered a heavyweight test case for the GeoPainter,
> and when everything works as expected we may then replace the VectorComposer.
> 
> The file would get loaded into a GeoDataDocument with only 1 Placemark, which in turn contains a MultiGeometry.
> All polys are appended there.
> 
> The polylines would get rendered with the georender plugin. It is possible now with the --enableFileView
> to switch the visibility of features for geodatadocuments, so that can show the performance hit quite easily.
> 
> This patch could land quite easily into trunk, as the feature is not replacing yet the traditional loading.
> Some rework however should happen so that maybe file loaders should be more generic. (plugins?)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1150967 
>   /trunk/KDE/kdeedu/marble/src/lib/FileLoader.h 1150967 
>   /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1150967 
> 
> Diff: http://reviewboard.kde.org/r/4673/diff
> 
> 
> Testing
> -------
> 
> Loading the PNT files with File->Open Map...
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100717/1c395ab8/attachment.htm