<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4673/">http://reviewboard.kde.org/r/4673/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>The patch looks nice :-)
GeoPainter is not yet able to fully replace the vectormap/vectorcomposer code. Reason is that part of the GeoDataLinearRing rendering isn't implemented yet (leads to drawing errors for Antarctica).
But as a "teaser" and for testing it's quite nice :-)</pre>
<br />
<p>- Torsten</p>
<br />
<p>On July 17th, 2010, 12:16 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble and Torsten Rahn.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated 2010-07-17 12:16:10</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Title says much.
This does not deprecate or change in any way the current PNT file loading
from DGML files, still using VectorComposer.
In fact, this can be considered a heavyweight test case for the GeoPainter,
and when everything works as expected we may then replace the VectorComposer.
The file would get loaded into a GeoDataDocument with only 1 Placemark, which in turn contains a MultiGeometry.
All polys are appended there.
The polylines would get rendered with the georender plugin. It is possible now with the --enableFileView
to switch the visibility of features for geodatadocuments, so that can show the performance hit quite easily.
This patch could land quite easily into trunk, as the feature is not replacing yet the traditional loading.
Some rework however should happen so that maybe file loaders should be more generic. (plugins?)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Loading the PNT files with File->Open Map...
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp <span style="color: grey">(1150967)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileLoader.h <span style="color: grey">(1150967)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp <span style="color: grey">(1150967)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4673/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>