[Marble-devel] Review Request: PlacemarkLayout: honour the visibility settings in GeoDataDocuments

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4674/
-----------------------------------------------------------

Review request for marble and Torsten Rahn.


Summary
-------

If the geodata for any reason says a placemark or its containers are not visible,
I think we would want to not display the placemark on the screen.

This patch honours visibility for all nested containers, such that if a
document/folder/placemark is not visible, then none of those should (recursively)
be displayed.

As discussed with tackat, the visibility is orthogonal to the properties like showCities,
so the checks for those stay and all conditions are necessary to layout the point.


Diffs
-----

  /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.cpp 1150967 
  /trunk/KDE/kdeedu/marble/src/lib/PlacemarkLayout.cpp 1150967 
  /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1150967 

Diff: http://reviewboard.kde.org/r/4674/diff


Testing
-------

with --enableFileView, toggle the visibility of document/folder/placemark and enjoy.
Also load documents which have visibility tags.


Thanks,

Thibaut

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100717/b3362b3c/attachment.htm