[Marble-devel] Review Request: Implementation of the KML time tags

[Bastian Holst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4253/#review6351
-----------------------------------------------------------


Good one.


/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimePrimitive.h
<http://reviewboard.kde.org/r/4253/#comment6092>

    I don' think we need an ID here. The id of an Object is stored in GeoDataObject. Have a look at the implementations of the other GeoData* classes.



/trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlTimeSpanTagHandler.cpp
<http://reviewboard.kde.org/r/4253/#comment6093>

    Could you remove newlines at the end of the lines.


- Bastian


On 2010-06-08 02:55:23, hjain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4253/
> -----------------------------------------------------------
> 
> (Updated 2010-06-08 02:55:23)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch implements the KML time tags. This patch contains some extra code in files in ~/marble/src/lib for testing purpose. Thus, kindly ignore that code.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.h 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.cpp 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/PlacemarkInfoDialog.cpp 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.h 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature_p.h 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimePrimitive.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimePrimitive.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimePrimitive_p.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimeSpan.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimeSpan.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimeSpan_p.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimeStamp.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimeStamp.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataTimeStamp_p.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlBeginTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlBeginTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.h 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlEndTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlEndTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlTimeSpanTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlTimeSpanTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlTimeStampTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlTimeStampTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlWhenTagHandler.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/handlers/kml/KmlWhenTagHandler.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.h 1130188 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.cpp 1130188 
> 
> Diff: http://reviewboard.kde.org/r/4253/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> hjain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100703/c9beb8f3/attachment.htm