[Marble-devel] Review Request: This should fix bug 237931: cfmakeraw doesn't exist on solaris

Bastian Holst bastianholst at gmx.de
Tue Jul 6 16:32:41 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4510/#review6384
-----------------------------------------------------------

Ship it!


Looks good.

- Bastian


On 2010-07-02 13:58:55, Wes Hardaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4510/
> -----------------------------------------------------------
> 
> (Updated 2010-07-02 13:58:55)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This fixes 237931 by checking for cfmakeraw and if it doesn't exist I think it does what it should.
> 
> 
> This addresses bug 237931.
>     https://bugs.kde.org/show_bug.cgi?id=237931
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/CMakeLists.txt 1144658 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/aprsconfig.h.in PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/plugins/render/aprs/posix_qextserialport.cpp 1144658 
> 
> Diff: http://reviewboard.kde.org/r/4510/diff
> 
> 
> Testing
> -------
> 
> Tested on linux, not solaris
> 
> 
> Thanks,
> 
> Wes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100706/3a757f73/attachment.htm 


More information about the Marble-devel mailing list