[Marble-devel] Review Request: Position accuracy indicator

[Dennis Nienhüser]

> On 2010-08-31 07:23:31, Torsten Rahn wrote:
> > Very very cool addition. I'm tempted to ask whether we should maybe backport this? :-)

I just looked at backporting it, but the code would be quite different and I kind of feel an antipathy against the GpsLayer/ClipPainter I'd have to use to implement it for 4.5... ABI wise it'd work.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5168/#review7308
-----------------------------------------------------------


On 2010-08-27 12:56:52, Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5168/
> -----------------------------------------------------------
> 
> (Updated 2010-08-27 12:56:52)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> The position marker is a bit hard to spot on the N900 when there's only time for a quick glance at the screen. To improve that, this patch adds a half-transparent red circle at the current position. To give it a right to exist other than enhanced visibility, its size depends on the accuracy of the current position. The circle can be interpreted as "the device is pretty sure that the real position is within the colored circle". See the screenshot for an example with little confidence.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/PositionTracking.h 1168534 
>   /trunk/KDE/kdeedu/marble/src/lib/PositionTracking.cpp 1168534 
>   /trunk/KDE/kdeedu/marble/src/lib/PositionTracking_p.h 1168534 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataAccuracy.h 1168534 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp 1168534 
>   /trunk/KDE/kdeedu/marble/src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.cpp 1168534 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp 1168534 
> 
> Diff: http://reviewboard.kde.org/r/5168/diff
> 
> 
> Testing
> -------
> 
> Works on my N900, no GPS mouse here currently to test it on my desktop system.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/5168/s/490/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100831/372e2c3e/attachment.htm