<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5168/">http://reviewboard.kde.org/r/5168/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 31st, 2010, 7:23 a.m., <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very very cool addition. I'm tempted to ask whether we should maybe backport this? :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just looked at backporting it, but the code would be quite different and I kind of feel an antipathy against the GpsLayer/ClipPainter I'd have to use to implement it for 4.5... ABI wise it'd work.
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On August 27th, 2010, 12:56 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated 2010-08-27 12:56:52</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The position marker is a bit hard to spot on the N900 when there's only time for a quick glance at the screen. To improve that, this patch adds a half-transparent red circle at the current position. To give it a right to exist other than enhanced visibility, its size depends on the accuracy of the current position. The circle can be interpreted as "the device is pretty sure that the real position is within the colored circle". See the screenshot for an example with little confidence.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works on my N900, no GPS mouse here currently to test it on my desktop system.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/PositionTracking.h <span style="color: grey">(1168534)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PositionTracking.cpp <span style="color: grey">(1168534)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/PositionTracking_p.h <span style="color: grey">(1168534)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataAccuracy.h <span style="color: grey">(1168534)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp <span style="color: grey">(1168534)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.cpp <span style="color: grey">(1168534)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(1168534)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5168/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/5168/s/490/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/27/marble-position-accuracy-indicator_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>